Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/feedback/feedback_uploader.h

Issue 225183018: Move feedback files into src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase to latest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback/feedback_uploader.h
diff --git a/chrome/browser/feedback/feedback_uploader.h b/components/feedback/feedback_uploader.h
similarity index 80%
rename from chrome/browser/feedback/feedback_uploader.h
rename to components/feedback/feedback_uploader.h
index 2bef774c0714901090f255501ed9c4610066e961..a2c6916afbf378f47bb1c2cc5ee178ba29b9e398 100644
--- a/chrome/browser/feedback/feedback_uploader.h
+++ b/components/feedback/feedback_uploader.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_
-#define CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_
+#ifndef COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_
+#define COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_
#include <queue>
#include <string>
@@ -26,21 +26,29 @@ class FeedbackReport;
// tried again when it's turn comes up next in the queue.
class FeedbackUploader : public base::SupportsWeakPtr<FeedbackUploader> {
public:
- explicit FeedbackUploader(const base::FilePath& path,
- base::SequencedWorkerPool* pool);
+ FeedbackUploader(const base::FilePath& path,
+ base::SequencedWorkerPool* pool);
+ FeedbackUploader(const base::FilePath& path,
+ base::SequencedWorkerPool* pool,
+ const std::string& url);
virtual ~FeedbackUploader();
// Queues a report for uploading.
- void QueueReport(const std::string& data);
+ virtual void QueueReport(const std::string& data);
base::FilePath GetFeedbackReportsPath() { return report_path_; }
+ bool QueueEmpty() const { return reports_queue_.empty(); }
+
protected:
friend class FeedbackUploaderTest;
+
struct ReportsUploadTimeComparator {
bool operator()(FeedbackReport* a, FeedbackReport* b) const;
};
+ void Init();
+
// Dispatches the report to be uploaded.
virtual void DispatchReport(const std::string& data) = 0;
@@ -74,4 +82,4 @@ class FeedbackUploader : public base::SupportsWeakPtr<FeedbackUploader> {
} // namespace feedback
-#endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_
+#endif // COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_

Powered by Google App Engine
This is Rietveld 408576698