Chromium Code Reviews| Index: components/feedback/feedback_uploader.h |
| diff --git a/chrome/browser/feedback/feedback_uploader.h b/components/feedback/feedback_uploader.h |
| similarity index 80% |
| rename from chrome/browser/feedback/feedback_uploader.h |
| rename to components/feedback/feedback_uploader.h |
| index 2bef774c0714901090f255501ed9c4610066e961..04ae0b4a25fea1d777392727aaebbfb25555023b 100644 |
| --- a/chrome/browser/feedback/feedback_uploader.h |
| +++ b/components/feedback/feedback_uploader.h |
| @@ -2,8 +2,8 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#ifndef CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_ |
| -#define CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_ |
| +#ifndef COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_ |
| +#define COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_ |
| #include <queue> |
| #include <string> |
| @@ -26,17 +26,24 @@ class FeedbackReport; |
| // tried again when it's turn comes up next in the queue. |
| class FeedbackUploader : public base::SupportsWeakPtr<FeedbackUploader> { |
| public: |
| - explicit FeedbackUploader(const base::FilePath& path, |
| - base::SequencedWorkerPool* pool); |
| + FeedbackUploader(const base::FilePath& path, |
| + base::SequencedWorkerPool* pool); |
| + FeedbackUploader(const base::FilePath& path, |
| + base::SequencedWorkerPool* pool, |
| + const std::string& url); |
| virtual ~FeedbackUploader(); |
| // Queues a report for uploading. |
| - void QueueReport(const std::string& data); |
| + virtual void QueueReport(const std::string& data); |
| base::FilePath GetFeedbackReportsPath() { return report_path_; } |
| + bool QueueEmpty() const { return reports_queue_.empty(); } |
| + |
| protected: |
| friend class FeedbackUploaderTest; |
| + friend class FeedbackServiceTest; |
|
jochen (gone - plz use gerrit)
2014/04/08 07:45:35
please move the tests into the component as well
achaulk
2014/04/09 20:09:22
Done
On 2014/04/08 07:45:35, jochen wrote:
|
| + |
| struct ReportsUploadTimeComparator { |
| bool operator()(FeedbackReport* a, FeedbackReport* b) const; |
| }; |
| @@ -74,4 +81,4 @@ class FeedbackUploader : public base::SupportsWeakPtr<FeedbackUploader> { |
| } // namespace feedback |
| -#endif // CHROME_BROWSER_FEEDBACK_FEEDBACK_UPLOADER_H_ |
| +#endif // COMPONENTS_FEEDBACK_FEEDBACK_UPLOADER_H_ |