components/feedback/DEPS - Issue 225183018: Move feedback files into src/components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/feedback/DEPS

Issue 225183018: Move feedback files into src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix deps, merge gyp targets, sync with latest Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+components/keyed_service",

	3 "+components/user_prefs",

	4 "+content/public/browser",
	jochen (gone - plz use gerrit) 2014/04/29 08:00:46 the gyp target doesn't have dependencies on any of the gyp target doesn't have dependencies on any of the above three targets? achaulk 2014/04/30 17:12:34 I thought I had added them. Done. Show quoted text On 2014/04/29 08:00:46, jochen (OOO Wed-Thu) wrote: > the gyp target doesn't have dependencies on any of the above three targets? I thought I had added them. Done.
	5 "+content/public/test",
	jochen (gone - plz use gerrit) 2014/04/29 08:00:46 Since you list individual content targets (which i Since you list individual content targets (which is great) you could also add "-content" at the top achaulk 2014/04/30 17:12:34 Done. Show quoted text On 2014/04/29 08:00:46, jochen (OOO Wed-Thu) wrote: > Since you list individual content targets (which is great) you could also add > "-content" at the top Done.
	6 "+net/base",

	7 "+net/url_request",

	8 "+third_party/zlib/google/zip.h",

	9 ]

OLD	NEW