Issue 225183016: [CSS Shapes] polygon y-value calc() args serialize incorrectly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225183016: [CSS Shapes] polygon y-value calc() args serialize incorrectly (Closed)

Created:
6 years, 8 months ago by rwlbuis

Modified:
6 years, 8 months ago

Reviewers:
Zoltan, eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, alancutter (OOO until 2018)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Shapes] polygon y-value calc() args serialize incorrectly The code hit ASSERT(isCalculation(value)) in CSSParser::createPrimitiveNumbericValue, because CSSParser::validUnit had been called on both coordinates, which set the value for m_parsedCalculation, but only one of the coordinates was calculation value. I reordered calling valudUnit and createPrimitiveNumbericValue to be called in the correct order on the coordinates. I added the new test case to parsing-test-utils.js. This is a merge of http://trac.webkit.org/changeset/166813 by Zoltan Horvath <zoltan@webkit.org>;. BUG=350182 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171689

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-test-utils.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/225183016/1

6 years, 8 months ago (2014-04-15 19:59:43 UTC) #5

Message was sent while issue was closed.

Change committed as 171689

Expand Messages | Collapse Messages