Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 225183015: Add support for GNU GLOBAL. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M Makefile View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 8 months ago (2014-04-07 18:45:54 UTC) #1
Sven Panne
LGTM. One could consider including third_party, too, but probably it's not worth it.
6 years, 8 months ago (2014-04-08 06:16:41 UTC) #2
Benedikt Meurer
6 years, 8 months ago (2014-04-08 06:19:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20557 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698