Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/objects-debug.cc

Issue 225183009: Use OrderedHashTables as the backing store of JSSet and JSMap (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Get rid of IsOrderedHashSet/Map methods Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 elements()->IsFixedArray() || 670 elements()->IsFixedArray() ||
671 elements()->IsFixedDoubleArray()); 671 elements()->IsFixedDoubleArray());
672 } 672 }
673 } 673 }
674 674
675 675
676 void JSSet::JSSetVerify() { 676 void JSSet::JSSetVerify() {
677 CHECK(IsJSSet()); 677 CHECK(IsJSSet());
678 JSObjectVerify(); 678 JSObjectVerify();
679 VerifyHeapPointer(table()); 679 VerifyHeapPointer(table());
680 CHECK(table()->IsHashTable() || table()->IsUndefined()); 680 CHECK(table()->IsOrderedHashTable() || table()->IsUndefined());
681 } 681 }
682 682
683 683
684 void JSMap::JSMapVerify() { 684 void JSMap::JSMapVerify() {
685 CHECK(IsJSMap()); 685 CHECK(IsJSMap());
686 JSObjectVerify(); 686 JSObjectVerify();
687 VerifyHeapPointer(table()); 687 VerifyHeapPointer(table());
688 CHECK(table()->IsHashTable() || table()->IsUndefined()); 688 CHECK(table()->IsOrderedHashTable() || table()->IsUndefined());
689 } 689 }
690 690
691 691
692 void JSWeakMap::JSWeakMapVerify() { 692 void JSWeakMap::JSWeakMapVerify() {
693 CHECK(IsJSWeakMap()); 693 CHECK(IsJSWeakMap());
694 JSObjectVerify(); 694 JSObjectVerify();
695 VerifyHeapPointer(table()); 695 VerifyHeapPointer(table());
696 CHECK(table()->IsHashTable() || table()->IsUndefined()); 696 CHECK(table()->IsHashTable() || table()->IsUndefined());
697 } 697 }
698 698
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1159 for (int i = 0; i < number_of_transitions(); ++i) { 1159 for (int i = 0; i < number_of_transitions(); ++i) {
1160 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false; 1160 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
1161 } 1161 }
1162 return true; 1162 return true;
1163 } 1163 }
1164 1164
1165 1165
1166 #endif // DEBUG 1166 #endif // DEBUG
1167 1167
1168 } } // namespace v8::internal 1168 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698