Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 225183009: Use OrderedHashTables as the backing store of JSSet and JSMap (Closed)

Created:
6 years, 8 months ago by adamk
Modified:
6 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Use OrderedHashTables as the backing store of JSSet and JSMap This also deletes ObjectHashSet as it's no longer used. BUG=v8:1793 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20585

Patch Set 1 #

Total comments: 2

Patch Set 2 : Get rid of IsOrderedHashSet/Map methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -166 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 7 chunks +7 lines, -40 lines 0 comments Download
M src/objects.cc View 4 chunks +8 lines, -85 lines 0 comments Download
M src/objects-debug.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M src/runtime.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
6 years, 8 months ago (2014-04-04 22:06:28 UTC) #1
Michael Starzinger
LGTM. Just one comment. https://codereview.chromium.org/225183009/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/225183009/diff/1/src/objects.h#newcode1080 src/objects.h:1080: V(OrderedHashTable) \ Since the OrderedHashTable ...
6 years, 8 months ago (2014-04-07 12:37:31 UTC) #2
adamk
https://codereview.chromium.org/225183009/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/225183009/diff/1/src/objects.h#newcode1080 src/objects.h:1080: V(OrderedHashTable) \ On 2014/04/07 12:37:31, Michael Starzinger wrote: > ...
6 years, 8 months ago (2014-04-07 23:50:01 UTC) #3
adamk
6 years, 8 months ago (2014-04-08 20:06:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698