Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 225183005: Refactoring editing/selection/13804.html (Closed)

Created:
6 years, 8 months ago by grzegorz
Modified:
6 years, 8 months ago
Reviewers:
tony, groby-ooo-7-16
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Refactoring editing/selection/13804.html This test does not need pixel baselines (linux, mac, win) to just check whether or not spelling marker appears on 'adf'. According to bug 295722, the test started using asynchronous spellchecking. Since the test verifies spelling behaviour, it was moved to editing/spelling directory. Its name was changed to spelling-backward.html. BUG=295722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170928

Patch Set 1 #

Messages

Total messages: 10 (0 generated)
grzegorz
6 years, 8 months ago (2014-04-04 13:11:28 UTC) #1
tony
LGTM!
6 years, 8 months ago (2014-04-04 16:49:51 UTC) #2
groby-ooo-7-16
RSLGTM
6 years, 8 months ago (2014-04-04 19:23:13 UTC) #3
grzegorz
The CQ bit was checked by g.czajkowski@samsung.com
6 years, 8 months ago (2014-04-04 20:56:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/225183005/1
6 years, 8 months ago (2014-04-04 20:56:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 21:06:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-04 21:06:46 UTC) #7
grzegorz
The CQ bit was checked by g.czajkowski@samsung.com
6 years, 8 months ago (2014-04-05 07:39:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/225183005/1
6 years, 8 months ago (2014-04-05 07:39:14 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-05 21:39:23 UTC) #10
Message was sent while issue was closed.
Change committed as 170928

Powered by Google App Engine
This is Rietveld 408576698