SkPDF: pull out SkPDFMakeCIDGlyphWidthsArray.cpp

src/pdf/SkPDFMakeCIDGlyphWidthsArray.h

+/*
+ * Copyright 2016 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+#ifndef SkPDFMakeCIDGlyphWidthsArray_DEFINED
+#define SkPDFMakeCIDGlyphWidthsArray_DEFINED
+
+#include "SkPDFTypes.h"
+
+class SkBitSet;
+class SkGlyphCache;
+
+/* PDF 32000-1:2008, page 270: "The array’s elements have a variable
+   format that can specify individual widths for consecutive CIDs or
+   one width for a range of CIDs". */
+sk_sp<SkPDFArray> SkPDFMakeCIDGlyphWidthsArray(SkGlyphCache* cache,
+                                               const SkBitSet* subset,
+                                               uint16_t emSize,
+                                               int16_t* defaultWidth);
+
+
+// used for unit tests.
+struct SkPDFAdvancerMock {
+    virtual ~SkPDFAdvancerMock() {}
+    virtual SkScalar operator()(SkGlyphID) const;
+    virtual int count() const;
+};
+sk_sp<SkPDFArray> SkPDFMakeCIDGlyphWidthsArray(const SkPDFAdvancerMock& mock,

[bungeman-skia, 2016/08/16 19:16:25]

Having this mocking stuff seems premature if we don't have any tests using it.
Also, it seems like it would be easier to write a test that uses a checked in
font to assert that the results are as expected.

[hal.canary, 2016/08/16 20:42:09]

Done.

+                                               const SkBitSet* subset,
+                                               uint16_t emSize,
+                                               int16_t* defaultWidth);
+
+#endif  // SkPDFMakeCIDGlyphWidthsArray_DEFINED