Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/compiler-dispatcher/compiler-dispatcher-job.h

Issue 2251713002: [Compiler] Add compile to CompilerDispatcherJob. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_compilerdispatcher
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler-dispatcher/compiler-dispatcher-job.h
diff --git a/src/compiler-dispatcher/compiler-dispatcher-job.h b/src/compiler-dispatcher/compiler-dispatcher-job.h
index 92127ff6c632bd86c20bebf574a06817349fba14..e3582b3165cc60085331b52306fb8a20aab6cb66 100644
--- a/src/compiler-dispatcher/compiler-dispatcher-job.h
+++ b/src/compiler-dispatcher/compiler-dispatcher-job.h
@@ -15,6 +15,7 @@ namespace v8 {
namespace internal {
class CompilationInfo;
+class CompilationJob;
class Isolate;
class JSFunction;
class ParseInfo;
@@ -28,7 +29,9 @@ enum class CompileJobStatus {
kInitial,
kReadyToParse,
kParsed,
+ kReadyToAnalyse,
kReadyToCompile,
+ kCompiled,
kFailed,
kDone,
};
@@ -50,9 +53,18 @@ class CompilerDispatcherJob {
// Transition from kReadyToParse to kParsed.
void Parse();
- // Transition from kParsed to kReadyToCompile (or kFailed).
+ // Transition from kParsed to kReadyToAnalyse.
void FinalizeParsingOnMainThread();
+ // Transition from kReadyToAnalyse to kReadyToCompile (or kFailed).
+ void PrepareToCompileOnMainThread();
+
+ // Transition from kReadyToCompile to kCompiled (or kFailed).
+ void Compile();
+
+ // Transition from kCompiled to kDone (or kFailed).
+ void FinalizeCompilingOnMainThread();
+
// Transition from kFailed to kDone.
void ReportErrorsOnMainThread();
@@ -77,6 +89,10 @@ class CompilerDispatcherJob {
std::unique_ptr<ParseInfo> parse_info_;
std::unique_ptr<Parser> parser_;
+ // Members required for compiling.
+ std::unique_ptr<CompilationInfo> compile_info_;
+ std::unique_ptr<CompilationJob> compile_job_;
+
bool can_parse_on_background_thread_;
DISALLOW_COPY_AND_ASSIGN(CompilerDispatcherJob);

Powered by Google App Engine
This is Rietveld 408576698