Introduce EphemeralRange::nodes() helper to traverse over a range.

third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
index 73d90630a003e57147bb3418f14174757b5f4ddb..7e845e4da9957ad7fff4f3560d958d3c4e710166 100644
--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
@@ -437,23 +437,24 @@ void DeleteSelectionCommand::deleteTextFromNode(Text* node, unsigned offset, uns
 
 void DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss(EditingState* editingState)
 {
-    Range* range = createRange(m_selectionToDelete.toNormalizedEphemeralRange());
-    Node* node = range->firstNode();
-    while (node && node != range->pastLastNode()) {
-        Node* nextNode = NodeTraversal::next(*node);
-        if (isHTMLStyleElement(*node) || isHTMLLinkElement(*node)) {
-            nextNode = NodeTraversal::nextSkippingChildren(*node);
-            Element* element = rootEditableElement(*node);
+    auto iterableRange = m_selectionToDelete.toNormalizedEphemeralRange().nodes();
+    for (auto it = iterableRange.begin(), end = iterableRange.end(); !it.isNull() && it != end;) {

[yosin_UTC9, 2016/08/18 02:11:09]

We could write this loop as (copied from another message):
by using node generator loop and node processing loop

Vector<Node> linkOrStyleElements;
for (Node& node : m_slectionToDelete.toNormalizedEphemeralRange().nodes()) {
  if (!isHTMLStyleElement(node) && !isHTMLLinkELement(node))
    continue;
  linkOrStyleElements.append(ndoe);
}

for (Node& node : linkOrStyleEements) {
  Element* rootEditable = rootEditableElement(node);
  if (!rootEditable)
    continue;
  removeNode(&node, editingState);
  appendNode(&node, element, editingState);
}

+        Node& node = *it;
+        if (isHTMLStyleElement(node) || isHTMLLinkElement(node)) {
+            Node* nextNode = NodeTraversal::nextSkippingChildren(node);
+            Element* element = rootEditableElement(node);
             if (element) {
-                removeNode(node, editingState);
+                removeNode(&node, editingState);
                 if (editingState->isAborted())
                     return;
-                appendNode(node, element, editingState);
+                appendNode(&node, element, editingState);
                 if (editingState->isAborted())
                     return;
             }
+            it.setCurrent(nextNode);
+        } else {
+            ++it;
         }
-        node = nextNode;
     }
 }