third_party/WebKit/Source/core/editing/EphemeralRange.cpp - Issue 2251703002: Introduce EphemeralRange::nodes() helper to traverse over a range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.cpp

Issue 2251703002: Introduce EphemeralRange::nodes() helper to traverse over a range. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move inRange() to EphemeralRange::nodes() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/EphemeralRange.h ('K') | « third_party/WebKit/Source/core/editing/EphemeralRange.h ('k') | third_party/WebKit/Source/core/editing/EphemeralRangeTest.cpp » ('j') | third_party/WebKit/Source/core/editing/EphemeralRangeTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EphemeralRange.cpp

diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.cpp b/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

index a1d9ff5e92e73a3e629236f7b19e5c7bb1e73a8c..911fdab418c930a926de5a0b3be9f4a077a299e0 100644

--- a/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.cpp

@@ -119,6 +119,13 @@ bool EphemeralRangeTemplate<Strategy>::isCollapsed() const

}

template <typename Strategy>

+typename EphemeralRangeTemplate<Strategy>::RangeTraversal

+EphemeralRangeTemplate<Strategy>::nodes() const

+ return RangeTraversal(m_startPosition.nodeAsRangeFirstNode(), m_endPosition.nodeAsRangePastLastNode());

+template <typename Strategy>

EphemeralRangeTemplate<Strategy> EphemeralRangeTemplate<Strategy>::rangeOfContents(const Node& node)

{

return EphemeralRangeTemplate<Strategy>(PositionTemplate<Strategy>::firstPositionInNode(&const_cast<Node&>(node)), PositionTemplate<Strategy>::lastPositionInNode(&const_cast<Node&>(node)));