Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.cpp

Issue 2251703002: Introduce EphemeralRange::nodes() helper to traverse over a range. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move inRange() to EphemeralRange::nodes() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingStyle.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.cpp b/third_party/WebKit/Source/core/editing/EditingStyle.cpp
index 163cbfb17e46d3197edc3447aae00c755f919209..ec4f61486720f7cf6ea2ba7978dbccdb576f636e 100644
--- a/third_party/WebKit/Source/core/editing/EditingStyle.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingStyle.cpp
@@ -1400,12 +1400,12 @@ WritingDirection EditingStyle::textDirectionForSelection(const VisibleSelection&
end = mostBackwardCaretPosition(selection.end());
DCHECK(end.document());
- Node* pastLast = Range::create(*end.document(), position.parentAnchoredEquivalent(), end.parentAnchoredEquivalent())->pastLastNode();
- for (Node* n = node; n && n != pastLast; n = NodeTraversal::next(*n)) {
- if (!n->isStyledElement())
+ const EphemeralRange caretRange(position.parentAnchoredEquivalent(), end.parentAnchoredEquivalent());
+ for (Node& n : caretRange.nodes()) {
+ if (!n.isStyledElement())
continue;
- CSSComputedStyleDeclaration* style = CSSComputedStyleDeclaration::create(n);
+ CSSComputedStyleDeclaration* style = CSSComputedStyleDeclaration::create(&n);
const CSSValue* unicodeBidi = style->getPropertyCSSValue(CSSPropertyUnicodeBidi);
if (!unicodeBidi || !unicodeBidi->isPrimitiveValue())
continue;

Powered by Google App Engine
This is Rietveld 408576698