Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.h

Issue 2251703002: Introduce EphemeralRange::nodes() helper to traverse over a range. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move default template to right place Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EphemeralRange.h
diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.h b/third_party/WebKit/Source/core/editing/EphemeralRange.h
index 5512100955b9ffc4b3645580a3fe62002ab97e87..77d8ec4804bf7c104d9b62ded8192aef1140ed55 100644
--- a/third_party/WebKit/Source/core/editing/EphemeralRange.h
+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.h
@@ -12,6 +12,42 @@ namespace blink {
class Document;
class Range;
+// We should restrict access to the unwanted version of |TraversalRange::end()| function.
+template <class Iterator>
+class TraversalRangeNodes : private TraversalRange<Iterator> {
+ STACK_ALLOCATED();
+public:
+ using StartNodeType = typename TraversalRange<Iterator>::StartNodeType;
+ TraversalRangeNodes(const StartNodeType* start, const StartNodeType* pastEndNode)
+ : TraversalRange<Iterator>(start), m_pastEndNode(pastEndNode) { }
+
+ using TraversalRange<Iterator>::begin;
+
+ Iterator end() { return Iterator(m_pastEndNode); }
+
+private:
+ const Member<const StartNodeType> m_pastEndNode;
+};
+
+// This class acts like |TraversalNextIterator| but in addition
+// it allows to set current position and checks |m_current| pointer before
+// dereferencing.
+template <class TraversalNext>
+class CheckedTraversalNextIterator : public TraversalIteratorBase<TraversalNext> {
+ STACK_ALLOCATED();
+
+ using TraversalIteratorBase<TraversalNext>::m_current;
+public:
+ using StartNodeType = typename TraversalNext::TraversalNodeType;
+ explicit CheckedTraversalNextIterator(const StartNodeType* start) : TraversalIteratorBase<TraversalNext>(const_cast<StartNodeType*>(start)) { }
+
+ void operator++()
+ {
+ DCHECK(m_current);
+ m_current = TraversalNext::next(*m_current);
+ }
+};
+
// Unlike |Range| objects, |EphemeralRangeTemplate| objects aren't relocated.
// You should not use |EphemeralRangeTemplate| objects after DOM modification.
//
@@ -38,6 +74,8 @@ template <typename Strategy>
class CORE_TEMPLATE_CLASS_EXPORT EphemeralRangeTemplate final {
STACK_ALLOCATED();
public:
+ using RangeTraversal = TraversalRangeNodes<CheckedTraversalNextIterator<Strategy>>;
+
EphemeralRangeTemplate(const PositionTemplate<Strategy>& start, const PositionTemplate<Strategy>& end);
EphemeralRangeTemplate(const EphemeralRangeTemplate& other);
// |position| should be |Position::isNull()| or in-document.
@@ -65,6 +103,8 @@ public:
}
bool isNotNull() const { return !isNull(); }
+ RangeTraversal nodes() const;
+
DEFINE_INLINE_TRACE()
{
visitor->trace(m_startPosition);
« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | third_party/WebKit/Source/core/editing/EphemeralRange.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698