Introduce EphemeralRange::nodes() helper to traverse over a range.

third_party/WebKit/Source/core/editing/EphemeralRange.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EphemeralRange_h
 #define EphemeralRange_h
 
 #include "core/editing/Position.h"
 
 namespace blink {
@@ skipping 77 matching lines @@
 extern template class CORE_EXTERN_TEMPLATE_EXPORT EphemeralRangeTemplate<EditingStrategy>;
 using EphemeralRange = EphemeralRangeTemplate<EditingStrategy>;
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 using EphemeralRangeInFlatTree = EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 
 // Returns a newly created |Range| object from |range| or |nullptr| if
 // |range.isNull()| returns true.
 CORE_EXPORT Range* createRange(const EphemeralRange& /* range */);
 
+namespace internal {
+
+// We should restrict access to the unwanted version of |TraversalRange::end()| function.
+template <class Iterator>
+class TraversalRangeImpl : private TraversalRange<Iterator> {
+    STACK_ALLOCATED();
+public:
+    using StartNodeType = typename TraversalRange<Iterator>::StartNodeType;
+    TraversalRangeImpl(const StartNodeType* start, const StartNodeType* pastEndNode)
+        : TraversalRange<Iterator>(start), m_pastEndNode(pastEndNode) { }
+
+    using TraversalRange<Iterator>::begin;
+
+    Iterator end() { return Iterator(m_pastEndNode); }
+
+private:
+    Member<const StartNodeType> m_pastEndNode;
+};
+
+using RangeTraversal = TraversalRangeImpl<TraversalNextIterator<NodeTraversal>>;
+using RangeTraversalInFlatTree = TraversalRangeImpl<TraversalNextIterator<FlatTreeTraversal>>;
+
+} // namespace internal
+
+internal::RangeTraversal inRange(const Position& start, const Position& end);

[Andrey Kraynov, 2016/08/16 10:02:11]

Should I move these functions to some static class like RangeTraversal?

[yosin_UTC9, 2016/08/17 01:45:31]

I don't think so.

How about EphmeralRange::nodes()?

# Example
Current:
    for (Node* node = range.startPosition().nodeAsRangeFirstNode(); node !=
pastLastNode; node = NodeTraversal::next(*node)) {

inRange:
    for (Node& node : inRange(range)) {

nodes:
    for (Node& node : EphemeralRange(range).nodes()) {

# Example 2
inRange:
    for (Node& node : inRange(start, end))
nodes:
    for (Node& node : EphmeralRange(start, end)::nodes()) {

+internal::RangeTraversalInFlatTree inRange(const PositionInFlatTree& start, const PositionInFlatTree& end);
+
+internal::RangeTraversal inRange(const EphemeralRange&);
+internal::RangeTraversalInFlatTree inRange(const EphemeralRangeInFlatTree&);
+
 } // namespace blink
 
 #endif