services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc - Issue 2251693005: services/ui: Implement MojoGpuMemoryBufferManager::CreateGpuMemoryBufferFromHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc

Issue 2251693005: services/ui: Implement MojoGpuMemoryBufferManager::CreateGpuMemoryBufferFromHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review issue. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc

diff --git a/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc b/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc

index 029b1c8331b3d6b99344c3a4be93379aa0859613..342670b1f499efa0be663afe2770642a8451ec4b 100644

--- a/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc

+++ b/services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc

@@ -27,8 +27,8 @@ MojoGpuMemoryBufferManager::CreateGpuMemoryBufferFromHandle(

const gfx::GpuMemoryBufferHandle& handle,

const gfx::Size& size,

gfx::BufferFormat format) {

- NOTIMPLEMENTED();

- return nullptr;

+ const gfx::BufferUsage usage = gfx::BufferUsage::GPU_READ;

+ return MojoGpuMemoryBufferImpl::CreateFromHandle(handle, size, format, usage);

}

gfx::GpuMemoryBuffer*

« services/ui/public/cpp/mojo_gpu_memory_buffer.cc ('K') | « services/ui/public/cpp/mojo_gpu_memory_buffer.cc ('k') | no next file » | no next file with comments »