Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2251693003: Rename "ContinuousSpellChecking" to "SpellChecking" in Blink (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, Nate Chapin, je_julie, kinuko+watch, loading-reviews_chromium.org, nektar+watch_chromium.org, nektarios, tyoshino+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename "ContinuousSpellChecking" to "SpellChecking" in Blink The concept "continuous spell checking" is meaningless as there is no non-continuous spell checking. Hence, this patch performs the following renamings to make them more accurate: - "isContinuousSpellCheckingEnabled" to "isSpellCheckingEnabled" - "enableContinuousSpellChecking" to "enableSpellChecking" - "toggleContinuousSpellChecking" to "toggleSpellChecingEnabled" BUG=638191 Committed: https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35 Cr-Commit-Position: refs/heads/master@{#412451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M components/spellcheck/renderer/spellcheck_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/misspellings.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-disable-enable.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-multiframe.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spelling-huge-text.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Text/normalize-crash-in-spell-checker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/SpellCheckerClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Xiaocheng
PTAL. There are some other occurrences of |ContinuousSpellCheck| left in the code base that are ...
4 years, 4 months ago (2016-08-17 03:59:23 UTC) #5
yosin_UTC9
lgtm Excellent! (^_^)b
4 years, 4 months ago (2016-08-17 04:15:05 UTC) #6
tkent
third_party/WebKit lgtm
4 years, 4 months ago (2016-08-17 04:16:40 UTC) #7
please use gerrit instead
lgtm
4 years, 4 months ago (2016-08-17 04:21:30 UTC) #8
Xiaocheng
Thanks for the review!
4 years, 4 months ago (2016-08-17 04:56:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251693003/1
4 years, 4 months ago (2016-08-17 05:07:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 05:12:26 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 05:14:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc40169f814a34448532c8ead3241275ab785d35
Cr-Commit-Position: refs/heads/master@{#412451}

Powered by Google App Engine
This is Rietveld 408576698