Move module initialization to DeclarationScope

Move module initialization to DeclarationScope

This moves language-mode initialization for MODULE_SCOPE from Scope::SetDefaults to the single constructor that needs to do it. The CL additionally makes it more obvious that scope-info-backed scopes always initialize language-mode unless WITH_SCOPE.

BUG=

Committed: https://crrev.com/095b28de219427965f5f22b9ab1757b6a6d187c8
Cr-Commit-Position: refs/heads/master@{#38650}

[Toon Verwaest, 2016-08-16 09:08:20]

verwaest@chromium.org changed reviewers:
+ neis@chromium.org

[Toon Verwaest, 2016-08-16 09:08:20]

ptal

[neis, 2016-08-16 09:21:36]

lgtm

https://codereview.chromium.org/2251683002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2251683002/diff/1/src/ast/scopes.cc#newcode138
src/ast/scopes.cc:138: num_heap_slots_ = scope_info_->ContextLength();
Can you make these uniform (scope_info_ vs scope_info)?

[Toon Verwaest, 2016-08-16 10:38:08]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-16 10:38:08]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2251683002/#ps20001
(title: "Unify")

[commit-bot: I haz the power, 2016-08-16 10:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 10:59:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 11:00:16]

Description was changed from

==========
Move module initialization to DeclarationScope

This moves language-mode initialization for MODULE_SCOPE from Scope::SetDefaults
to the single constructor that needs to do it. The CL additionally makes it more
obvious that scope-info-backed scopes always initialize language-mode unless
WITH_SCOPE.

BUG=
==========

to

==========
Move module initialization to DeclarationScope

This moves language-mode initialization for MODULE_SCOPE from Scope::SetDefaults
to the single constructor that needs to do it. The CL additionally makes it more
obvious that scope-info-backed scopes always initialize language-mode unless
WITH_SCOPE.

BUG=

Committed: https://crrev.com/095b28de219427965f5f22b9ab1757b6a6d187c8
Cr-Commit-Position: refs/heads/master@{#38650}
==========

[commit-bot: I haz the power, 2016-08-16 11:00:17]

Patchset 2 (id:??) landed as
https://crrev.com/095b28de219427965f5f22b9ab1757b6a6d187c8
Cr-Commit-Position: refs/heads/master@{#38650}