Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: ui/accessibility/BUILD.gn

Issue 2251673004: remove duplicate atk GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make use of use_atk instead of use_x11 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/BUILD.gn
diff --git a/ui/accessibility/BUILD.gn b/ui/accessibility/BUILD.gn
index 2c9b49dea289a9c21ae1e84497fc02e6d6910f95..4c03ce91d34e55a5f9e7465509fafdb339a30adc 100644
--- a/ui/accessibility/BUILD.gn
+++ b/ui/accessibility/BUILD.gn
@@ -11,34 +11,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
-if (use_x11) {
- pkg_config("atk") {
- packages = [ "atk" ]
- atk_lib_dir = exec_script(pkg_config_script,
- pkg_config_args + [
- "--libdir",
- "atk",
- ],
- "string")
- defines = [ "ATK_LIB_DIR=\"$atk_lib_dir\"" ]
- }
-
- # gn orders flags on a target before flags from configs. The default config
- # adds -Wall, and these flags have to be after -Wall -- so they need to come
- # from a config and can't be on the target directly.
- config("atk_warnings") {
- cflags = [
- # glib uses the pre-c++11 typedef-as-static_assert hack.
- "-Wno-unused-local-typedef",
-
- # G_DEFINE_TYPE automatically generates a *get_instance_private
- # inline function after glib 2.37. That's unused. Prevent to
- # complain about it.
- "-Wno-unused-function",
- ]
- }
-}
-
component("accessibility") {
sources = [
"ax_node.cc",
@@ -104,10 +76,7 @@ component("accessibility") {
"platform/ax_platform_node_auralinux.h",
]
- configs += [
- ":atk",
- ":atk_warnings",
- ]
+ configs += [ "//build/config/linux/atk" ]
if (use_gconf) {
configs += [ "//build/config/linux/gconf" ]
« no previous file with comments | « content/browser/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698