remove duplicate atk GN config

remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297
TBR=agrieve@chromium.org

Committed: https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc
Cr-Commit-Position: refs/heads/master@{#412680}

[Mostyn Bramley-Moore, 2016-08-17 00:41:05]

Description was changed from

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.
==========

to

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.
==========

[Mostyn Bramley-Moore, 2016-08-17 00:42:29]

Description was changed from

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.
==========

to

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297
==========

[Mostyn Bramley-Moore, 2016-08-17 00:42:29]

mostynb@opera.com changed reviewers:
+ agrieve@chromium.org, brettw@chromium.org, mforce2@gmail.com,
raphael.kubo.da.costa@intel.com

[Mostyn Bramley-Moore, 2016-08-17 00:42:39]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 00:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mostyn Bramley-Moore, 2016-08-17 00:43:28]

@brettw, agrieve: please take a look at this cleanup (related to the discussion
in https://codereview.chromium.org/2248043002/).

[commit-bot: I haz the power, 2016-08-17 00:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 00:46:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mostyn Bramley-Moore, 2016-08-17 00:48:08]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 00:48:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 01:34:56]

Dry run: This issue passed the CQ dry run.

[Raphael Kubo da Costa (rakuco), 2016-08-17 12:41:42]

Looks great to me!

[brettw, 2016-08-17 18:06:12]

This looks good. But it looks like every place we do the "atk" config we also do
the "warnings" one. Can we combine these so callers only have to reference one?

I'm not sure if the pkgconfig thing lets one set cflags. We could add that
ability, or rename the pkgconfig one and make a new config that references both
of the existing ones.

[Mostyn Bramley-Moore, 2016-08-17 21:58:08]

The CQ bit was checked by mostynb@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:58:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mostyn Bramley-Moore, 2016-08-17 22:00:44]

On 2016/08/17 18:06:12, brettw (ping on IM after 24h) wrote:
> This looks good. But it looks like every place we do the "atk" config we also
do
> the "warnings" one. Can we combine these so callers only have to reference
one?

There was one instance in ui/views/BUILD.gn that didn't use the warnings config-
but let's see if we can add the extra warnings there too.

> I'm not sure if the pkgconfig thing lets one set cflags. We could add that
> ability, or rename the pkgconfig one and make a new config that references
both
> of the existing ones.

The pkg_config template doesn't support that, so I simply turned the warnings
config into a wrapper, renamed it to "atk" and used that in the client
locations.

[brettw, 2016-08-17 22:03:52]

lgtm

[Mostyn Bramley-Moore, 2016-08-17 22:05:25]

Description was changed from

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297
==========

to

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org
==========

[Mostyn Bramley-Moore, 2016-08-17 22:08:21]

The CQ bit was unchecked by mostynb@opera.com

[Mostyn Bramley-Moore, 2016-08-17 22:08:29]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2016-08-17 22:08:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:01:21]

Description was changed from

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org
==========

to

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org
==========

[commit-bot: I haz the power, 2016-08-17 23:01:22]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-08-17 23:19:40]

Description was changed from

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org
==========

to

==========
remove duplicate atk GN config

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org

Committed: https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc
Cr-Commit-Position: refs/heads/master@{#412680}
==========

[commit-bot: I haz the power, 2016-08-17 23:19:42]

Patchset 5 (id:??) landed as
https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc
Cr-Commit-Position: refs/heads/master@{#412680}