Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2251673004: remove duplicate atk GN config (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove duplicate atk GN config The atk GN configs were moved to a separate GN file in https://codereview.chromium.org/1909273002 but it appears that the original configs were not removed, and are still referenced. Let's remove the old configs and just use the new ones. And while we're at it, add an assertion to check that glib is enabled when atk is. BUG=632297 TBR=agrieve@chromium.org Committed: https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc Cr-Commit-Position: refs/heads/master@{#412680}

Patch Set 1 : remove duplicate atk GN config #

Patch Set 2 : add use_atk / use_glib assertion #

Patch Set 3 : add missing import #

Patch Set 4 : use a single atk config in clients #

Patch Set 5 : make use of use_atk instead of use_x11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M build/config/linux/atk/BUILD.gn View 1 2 3 3 chunks +9 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 3 2 chunks +1 line, -32 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Mostyn Bramley-Moore
@brettw, agrieve: please take a look at this cleanup (related to the discussion in https://codereview.chromium.org/2248043002/).
4 years, 4 months ago (2016-08-17 00:43:28 UTC) #6
Raphael Kubo da Costa (rakuco)
Looks great to me!
4 years, 4 months ago (2016-08-17 12:41:42 UTC) #13
brettw
This looks good. But it looks like every place we do the "atk" config we ...
4 years, 4 months ago (2016-08-17 18:06:12 UTC) #14
Mostyn Bramley-Moore
On 2016/08/17 18:06:12, brettw (ping on IM after 24h) wrote: > This looks good. But ...
4 years, 4 months ago (2016-08-17 22:00:44 UTC) #17
brettw
lgtm
4 years, 4 months ago (2016-08-17 22:03:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251673004/70001
4 years, 4 months ago (2016-08-17 22:08:50 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 4 months ago (2016-08-17 23:01:22 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:19:42 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/902b5282bf5c0314c801fa29a27ae1e4d39a56bc
Cr-Commit-Position: refs/heads/master@{#412680}

Powered by Google App Engine
This is Rietveld 408576698