Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Side by Side Diff: ash/BUILD.gn

Issue 2251643011: Move Ash-specific vector icons to ash/common/resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 import("//ui/base/ui_features.gni") 8 import("//ui/base/ui_features.gni")
9 9
10 assert(use_aura) 10 assert(use_aura)
11 assert(enable_hidpi) 11 assert(enable_hidpi)
12 12
13 gypi_values = exec_script("//build/gypi_to_gn.py", 13 gypi_values = exec_script("//build/gypi_to_gn.py",
14 [ rebase_path("ash.gyp") ], 14 [ rebase_path("ash.gyp") ],
15 "scope", 15 "scope",
16 [ "ash.gyp" ]) 16 [ "ash.gyp" ])
17 17
18 vector_icons_sources_gypi =
19 exec_script("//build/gypi_to_gn.py",
20 [ rebase_path("common/resources/vector_icons_sources.gypi") ],
sadrul 2016/08/30 19:31:08 This gypi is not used anywhere else, so just list
oshima 2016/08/31 00:11:44 +1
tdanderson 2016/08/31 22:18:20 Done.
21 "scope",
22 [ "common/resources/vector_icons_sources.gypi" ])
23
24 vector_icons_cc_file = "$target_gen_dir/common/resources/vector_icons.cc"
25 vector_icons_h_file = "$target_gen_dir/common/resources/vector_icons.h"
26
18 component("ash") { 27 component("ash") {
19 sources = gypi_values.ash_sources 28 sources = gypi_values.ash_sources
20 29
30 sources += [
31 vector_icons_cc_file,
32 vector_icons_h_file,
33 ]
34
21 configs += [ "//build/config:precompiled_headers" ] 35 configs += [ "//build/config:precompiled_headers" ]
22 defines = [ "ASH_IMPLEMENTATION" ] 36 defines = [ "ASH_IMPLEMENTATION" ]
23 37
24 public_deps = [ 38 public_deps = [
25 "//ash/common/strings", 39 "//ash/common/strings",
26 "//ash/resources", 40 "//ash/resources",
27 ] 41 ]
28 deps = [ 42 deps = [
43 ":aggregate_vector_icons",
29 "//ash/autoclick/common:autoclick", 44 "//ash/autoclick/common:autoclick",
30 "//ash/touch_hud", 45 "//ash/touch_hud",
31 "//base", 46 "//base",
32 "//base:i18n", 47 "//base:i18n",
33 "//base/third_party/dynamic_annotations", 48 "//base/third_party/dynamic_annotations",
34 "//cc", 49 "//cc",
35 "//components/device_event_log", 50 "//components/device_event_log",
36 "//components/onc", 51 "//components/onc",
37 "//components/signin/core/account_id", 52 "//components/signin/core/account_id",
38 "//components/user_manager", 53 "//components/user_manager",
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 } 159 }
145 160
146 if (!use_ozone) { 161 if (!use_ozone) {
147 sources -= [ 162 sources -= [
148 "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc", 163 "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.cc",
149 "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h", 164 "wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_ozone.h",
150 ] 165 ]
151 } 166 }
152 } 167 }
153 168
169 action("aggregate_vector_icons") {
170 script = "//ui/gfx/vector_icons/aggregate_vector_icons.py"
171 inputs = vector_icons_sources_gypi.ash
172
173 outputs = [
174 vector_icons_cc_file,
175 vector_icons_h_file,
176 ]
177
178 response_file_contents = rebase_path(inputs, root_build_dir)
179
180 args = [
181 "--working_directory=" + rebase_path("common/resources/vector_icons/"),
182 "--file_list={{response_file_name}}",
183 "--output_cc=" + rebase_path(vector_icons_cc_file, root_build_dir),
184 "--output_h=" + rebase_path(vector_icons_h_file, root_build_dir),
185 ]
186 }
187
154 component("ash_with_content") { 188 component("ash_with_content") {
155 sources = gypi_values.ash_with_content_sources 189 sources = gypi_values.ash_with_content_sources
156 190
157 defines = [ "ASH_WITH_CONTENT_IMPLEMENTATION" ] 191 defines = [ "ASH_WITH_CONTENT_IMPLEMENTATION" ]
158 192
159 public_deps = [ 193 public_deps = [
160 ":ash", 194 ":ash",
161 ] 195 ]
162 deps = [ 196 deps = [
163 "//base", 197 "//base",
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 configs += [ "//build/config/win:windowed" ] 522 configs += [ "//build/config/win:windowed" ]
489 deps += [ "//sandbox" ] 523 deps += [ "//sandbox" ]
490 } 524 }
491 525
492 if (is_chromeos) { 526 if (is_chromeos) {
493 deps += [ "//device/bluetooth" ] 527 deps += [ "//device/bluetooth" ]
494 } 528 }
495 } 529 }
496 # When adding support for isolates, please have a look at run-time dependencies 530 # When adding support for isolates, please have a look at run-time dependencies
497 # in the ash_unittests_run target in ash.gyp. 531 # in the ash_unittests_run target in ash.gyp.
OLDNEW
« no previous file with comments | « no previous file | ash/common/resources/vector_icons/system_menu_keyboard.icon » ('j') | ash/common/system/ime/tray_ime_chromeos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698