Move Ash-specific vector icons to ash/common/resources

Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move
Ash-specific .icon files out of ui/gfx/vector_icons
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual

Committed: https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3
Cr-Commit-Position: refs/heads/master@{#415782}

[tdanderson, 2016-08-19 20:54:47]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 20:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 21:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:05:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tdanderson, 2016-08-19 21:23:34]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org, sadrul@chromium.org

[tdanderson, 2016-08-19 21:23:35]

Sadrul and Evan: after trying a few things this is the path that seems most
promising. I still need to modify ash/BUILD.gn, aggregate_vector_icons.py, etc.,
but please let me know if you have any initial (nit-free) feedback.

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn#newcode21
ash/BUILD.gn:21: sources += [
Lines 21-25 are only included for this WIP CL. The actual changes to this file
will be similar to what is seen in ui/gfx/BUILD.gn for vector icons - I would
more or less be copying the code for action("aggregate_vector_icons").

https://codereview.chromium.org/2251643011/diff/1/ash/common/resources/vector...
File ash/common/resources/vector_icons.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ash/common/resources/vector...
ash/common/resources/vector_icons.cc:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
This is what vector_icons.cc would look like after it is generated by
aggregate_vector_icons using a modified vector_icons.cc.template. (Obviously I
still need to modify aggregate_vector_icons.py accordingly.)

https://codereview.chromium.org/2251643011/diff/1/ash/common/resources/vector...
File ash/common/resources/vector_icons.h (right):

https://codereview.chromium.org/2251643011/diff/1/ash/common/resources/vector...
ash/common/resources/vector_icons.h:1: // Copyright 2016 The Chromium Authors.
All rights reserved.
This is what vector_icons.h would look like after it is generated by
aggregate_vector_icons using a modified vector_icons.h.template.

Note that the constant is within the ash namespace, so it would be possible to
have foo::BAR and foo2::BAR (i.e., icon 'names' would not have to be unique
system-wide).

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
ash/common/system/ime/tray_ime_chromeos.cc:77:
gfx::CreateVectorIcon(&ash::SYSTEM_MENU_KEYBOARD, kMenuIconColor));
Sample call site. I'm not a fan of the ALL_CAPS_NAME (and it violates the style
guide) so I'll change aggregate_vector_icons.py to map
"system_menu_keyboard.icon" to the const name "kSystemMenuKeyboard" (although
this could possibly lead to confusion).

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc...
ui/gfx/paint_vector_icon.cc:528: : kReferenceSizeDip;
Alternatively, we could do this work upfront and add a |canvas_dimensions|
member to the VectorIcon struct.

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc...
ui/gfx/paint_vector_icon.cc:562: ImageSkia CreateVectorIconFromSource(const
std::string& source,
As a side note, vector_example (in views_examples) will also need to change to
allow previewing images.

[sadrul, 2016-08-22 15:14:06]

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn#newcode21
ash/BUILD.gn:21: sources += [
On 2016/08/19 21:23:35, tdanderson wrote:
> Lines 21-25 are only included for this WIP CL. The actual changes to this file
> will be similar to what is seen in ui/gfx/BUILD.gn for vector icons - I would
> more or less be copying the code for action("aggregate_vector_icons").

Consider creating a gn template instead
(https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/languag...)

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc...
ui/gfx/paint_vector_icon.cc:528: : kReferenceSizeDip;
On 2016/08/19 21:23:35, tdanderson wrote:
> Alternatively, we could do this work upfront and add a |canvas_dimensions|
> member to the VectorIcon struct.

Yeah, that sounds like a good option. (may be a base::Optional<>)

[Evan Stade, 2016-08-22 16:46:54]

nice, I like

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
ash/common/system/ime/tray_ime_chromeos.cc:77:
gfx::CreateVectorIcon(&ash::SYSTEM_MENU_KEYBOARD, kMenuIconColor));
On 2016/08/19 21:23:35, tdanderson wrote:
> Sample call site. I'm not a fan of the ALL_CAPS_NAME (and it violates the
style
> guide) so I'll change aggregate_vector_icons.py to map
> "system_menu_keyboard.icon" to the const name "kSystemMenuKeyboard" (although
> this could possibly lead to confusion).

sg (You can append Icon if you want, it simply wasn't necessary when you had
gfx::VectorIconId:: before the name)

Also, why is this passed by pointer? wouldn't ash::kSystemMenuKeyboard be
sufficient?

[tdanderson, 2016-08-25 21:52:42]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:53:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-08-25 21:54:32]

Evan and Sadrul, please review Patch Set 2.

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/1/ash/BUILD.gn#newcode21
ash/BUILD.gn:21: sources += [
On 2016/08/22 15:14:05, sadrul wrote:
> On 2016/08/19 21:23:35, tdanderson wrote:
> > Lines 21-25 are only included for this WIP CL. The actual changes to this
file
> > will be similar to what is seen in ui/gfx/BUILD.gn for vector icons - I
would
> > more or less be copying the code for action("aggregate_vector_icons").
> 
> Consider creating a gn template instead
>
(https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/languag...)

Will re-visit this idea afterwards.

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ash/common/system/ime/tray_...
ash/common/system/ime/tray_ime_chromeos.cc:77:
gfx::CreateVectorIcon(&ash::SYSTEM_MENU_KEYBOARD, kMenuIconColor));
On 2016/08/22 16:46:54, Evan Stade (ooo wed-thurs) wrote:
> On 2016/08/19 21:23:35, tdanderson wrote:
> > Sample call site. I'm not a fan of the ALL_CAPS_NAME (and it violates the
> style
> > guide) so I'll change aggregate_vector_icons.py to map
> > "system_menu_keyboard.icon" to the const name "kSystemMenuKeyboard"
(although
> > this could possibly lead to confusion).
> 
> sg (You can append Icon if you want, it simply wasn't necessary when you had
> gfx::VectorIconId:: before the name)

Icon appended.

> 
> Also, why is this passed by pointer? wouldn't ash::kSystemMenuKeyboard be
> sufficient?

Changed in next patch set.

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2251643011/diff/1/ui/gfx/paint_vector_icon.cc...
ui/gfx/paint_vector_icon.cc:528: : kReferenceSizeDip;
On 2016/08/22 15:14:05, sadrul wrote:
> On 2016/08/19 21:23:35, tdanderson wrote:
> > Alternatively, we could do this work upfront and add a |canvas_dimensions|
> > member to the VectorIcon struct.
> 
> Yeah, that sounds like a good option. (may be a base::Optional<>)

Will keep in mind as part of follow-up.

[commit-bot: I haz the power, 2016-08-26 00:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:24:19]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-08-26 22:34:06]

lgtm!

update description?

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_types.h
File ui/gfx/vector_icon_types.h (right):

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_type...
ui/gfx/vector_icon_types.h:15: struct VectorIcon;
why is this here?

[sadrul, 2016-08-30 19:31:08]

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn#newcode20
ash/BUILD.gn:20: [ rebase_path("common/resources/vector_icons_sources.gypi") ],
This gypi is not used anywhere else, so just list the files in this gn file. (or
some gni file and import that from this file)

[tdanderson, 2016-08-30 21:41:15]

Description was changed from

==========
[early WIP] Move Ash-specific vector icons to ash/common/resources

Not for review.

BUG=626786
==========

to

==========
Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move 
Ash-specific .icon files out of ui/gfx/vector_icons 
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual
==========

[tdanderson, 2016-08-30 21:45:14]

tdanderson@chromium.org changed reviewers:
+ jamescook@chromium.org, oshima@chromium.org

[tdanderson, 2016-08-30 21:45:15]

James and Oshima, can you please take a look at ash/? I chose
ash/common/resources as the place to put the vector icons to avoid violating
DEPS rules. Would ash/resources be a better choice (requiring whitelisting that
in DEPS)?

[James Cook, 2016-08-30 22:10:12]

For ash I would just use //ash/resources and allow it in DEPS.

(I like this CL -- it's nice to see ash resources live in //ash.)

https://codereview.chromium.org/2251643011/diff/20001/ash/common/system/ime/t...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2251643011/diff/20001/ash/common/system/ime/t...
ash/common/system/ime/tray_ime_chromeos.cc:77:
gfx::CreateVectorIcon(ash::kSystemMenuKeyboardIcon, kMenuIconColor));
nit: ash:: not needed

[oshima, 2016-08-31 00:11:44]

nice, lgtm my bits with one optional suggestion.

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn#newcode20
ash/BUILD.gn:20: [ rebase_path("common/resources/vector_icons_sources.gypi") ],
On 2016/08/30 19:31:08, sadrul wrote:
> This gypi is not used anywhere else, so just list the files in this gn file.
(or
> some gni file and import that from this file)

+1

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_types.h
File ui/gfx/vector_icon_types.h (right):

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_type...
ui/gfx/vector_icon_types.h:77: gfx::PathElement* path;
would it be better to have initializer (=nullptr;) ?

(but defer to vector icon owners decision)

[Evan Stade, 2016-08-31 00:47:03]

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:368: return id_ != VectorIconId::VECTOR_ICON_NONE;
I can't actually remember why this doesn't just always return true. I don't
think id_ should ever be VECTOR_ICON_NONE except if you've used the second
constructor in which case this check especially doesn't seem correct.

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:494: const VectorIcon kNoneIcon = {nullptr,
nullptr};
you can just do = {};

but I also like oshima's suggestion to default-initialize to nullptr.

[tdanderson, 2016-08-31 19:47:05]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 19:47:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:52:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2016-08-31 20:04:36]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:09:47]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tdanderson, 2016-08-31 20:26:46]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:27:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:53:30]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2016-08-31 22:18:21]

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2251643011/diff/20001/ash/BUILD.gn#newcode20
ash/BUILD.gn:20: [ rebase_path("common/resources/vector_icons_sources.gypi") ],
On 2016/08/31 00:11:44, oshima wrote:
> On 2016/08/30 19:31:08, sadrul wrote:
> > This gypi is not used anywhere else, so just list the files in this gn file.
> (or
> > some gni file and import that from this file)
> 
> +1

Done.

https://codereview.chromium.org/2251643011/diff/20001/ash/common/system/ime/t...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2251643011/diff/20001/ash/common/system/ime/t...
ash/common/system/ime/tray_ime_chromeos.cc:77:
gfx::CreateVectorIcon(ash::kSystemMenuKeyboardIcon, kMenuIconColor));
On 2016/08/30 22:10:12, James Cook wrote:
> nit: ash:: not needed

Done.

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/paint_vector_ico...
File ui/gfx/paint_vector_icon.cc (right):

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/paint_vector_ico...
ui/gfx/paint_vector_icon.cc:494: const VectorIcon kNoneIcon = {nullptr,
nullptr};
On 2016/08/31 00:47:01, Evan Stade wrote:
> you can just do = {};
> 
> but I also like oshima's suggestion to default-initialize to nullptr.

Done.

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_types.h
File ui/gfx/vector_icon_types.h (right):

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_type...
ui/gfx/vector_icon_types.h:15: struct VectorIcon;
On 2016/08/26 22:34:06, Evan Stade wrote:
> why is this here?

Gone.

https://codereview.chromium.org/2251643011/diff/20001/ui/gfx/vector_icon_type...
ui/gfx/vector_icon_types.h:77: gfx::PathElement* path;
On 2016/08/31 00:11:44, oshima wrote:
> would it be better to have initializer (=nullptr;) ?
> 
> (but defer to vector icon owners decision)

Done.

[tdanderson, 2016-08-31 22:18:28]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2016-08-31 22:18:28]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2251643011/#ps100001
(title: "fix sources again")

[commit-bot: I haz the power, 2016-08-31 22:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:25:40]

Description was changed from

==========
Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move 
Ash-specific .icon files out of ui/gfx/vector_icons 
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual
==========

to

==========
Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move 
Ash-specific .icon files out of ui/gfx/vector_icons 
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual
==========

[commit-bot: I haz the power, 2016-08-31 22:25:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-31 22:27:16]

Description was changed from

==========
Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move 
Ash-specific .icon files out of ui/gfx/vector_icons 
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual
==========

to

==========
Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move
Ash-specific .icon files out of ui/gfx/vector_icons
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG=626786
TEST=manual

Committed: https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3
Cr-Commit-Position: refs/heads/master@{#415782}
==========

[commit-bot: I haz the power, 2016-08-31 22:27:17]

Patchset 6 (id:??) landed as
https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3
Cr-Commit-Position: refs/heads/master@{#415782}