Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2251643008: Tessellator: better fix for reused-edges issue. (Closed)

Created:
4 years, 4 months ago by Stephen White
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tessellator: better fix for reused-edges issue. The GrTessellator fix for doubly-added edges in https://codereview.chromium.org/2259493002/ could leave a MonotonePoly with zero edges. This is a problem for Poly::addEdge(), which assumes that MonotonePolys always have at least one edge. The fix is to move the check and early-out up to Poly::addEdge(). This should also tighten up the vertex count. (Unfortunately, the only repro I have for this issue is very convoluted, and requires non-landed code.) BUG=skia:5636 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251643008 Committed: https://skia.googlesource.com/skia/+/212c7c389e81053b84a3ed7775f2031d76d5ee70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/gpu/GrTessellator.cpp View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Stephen White
robertphillips@: PTAL. Thanks!
4 years, 4 months ago (2016-08-18 15:37:24 UTC) #6
robertphillips
lgtm
4 years, 4 months ago (2016-08-18 17:18:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251643008/1
4 years, 4 months ago (2016-08-18 17:19:33 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:20:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/212c7c389e81053b84a3ed7775f2031d76d5ee70

Powered by Google App Engine
This is Rietveld 408576698