Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2251643004: Convert editing/style/style-3681552-fix-002.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/style-3681552-fix-002.html to use w3c test harness This patch converts "editing/style/style-3681552-fix-002.html" to use w3c test harness and integrates into "typing_style.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/bada043222ed89a2b8cac4248e84274025c6f774 Cr-Commit-Position: refs/heads/master@{#412471}

Patch Set 1 : 2016-08-17T14:19:34 #

Total comments: 2

Patch Set 2 : 2016-08-17T15:30:11 #

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-17 05:56:14 UTC) #5
Xiaocheng
https://codereview.chromium.org/2251643004/diff/1/third_party/WebKit/LayoutTests/editing/style/typing_style.html File third_party/WebKit/LayoutTests/editing/style/typing_style.html (right): https://codereview.chromium.org/2251643004/diff/1/third_party/WebKit/LayoutTests/editing/style/typing_style.html#newcode26 third_party/WebKit/LayoutTests/editing/style/typing_style.html:26: 'Delete all styled characters then typing character does not ...
4 years, 4 months ago (2016-08-17 06:04:25 UTC) #6
yosin_UTC9
PTAL https://codereview.chromium.org/2251643004/diff/1/third_party/WebKit/LayoutTests/editing/style/typing_style.html File third_party/WebKit/LayoutTests/editing/style/typing_style.html (right): https://codereview.chromium.org/2251643004/diff/1/third_party/WebKit/LayoutTests/editing/style/typing_style.html#newcode26 third_party/WebKit/LayoutTests/editing/style/typing_style.html:26: 'Delete all styled characters then typing character does ...
4 years, 4 months ago (2016-08-17 06:31:18 UTC) #10
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-17 06:37:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251643004/20001
4 years, 4 months ago (2016-08-17 06:56:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 08:02:41 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:14:22 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bada043222ed89a2b8cac4248e84274025c6f774
Cr-Commit-Position: refs/heads/master@{#412471}

Powered by Google App Engine
This is Rietveld 408576698