content/browser/download/download_resource_handler.cc - Issue 2251643003: Remove the BeginSaveFile and BeginDownload methods from ResourceDispatcherHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_resource_handler.cc

Issue 2251643003: Remove the BeginSaveFile and BeginDownload methods from ResourceDispatcherHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the blob code to RDHI::BeginURLRequest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_manager_impl_unittest.cc ('K') | « content/browser/download/download_resource_handler.h ('k') | content/browser/download/save_file_manager.cc » ('j') | content/browser/download/save_file_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_resource_handler.cc

diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc

index 05d22a8ee73cfe46f093aa7503646ed3a2bb6f98..c2d73939a4031eca04d581dbdd06c93c4eafbcc4 100644

--- a/content/browser/download/download_resource_handler.cc

+++ b/content/browser/download/download_resource_handler.cc

@@ -129,6 +129,15 @@ DownloadResourceHandler::~DownloadResourceHandler() {

}

+// static

+std::unique_ptr<ResourceHandler> DownloadResourceHandler::Create(

+ net::URLRequest* request) {

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

+ std::unique_ptr<ResourceHandler> handler(

+ new DownloadResourceHandler(request));

+ return handler;

bool DownloadResourceHandler::OnRequestRedirected(

const net::RedirectInfo& redirect_info,

ResourceResponse* response,