Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2251643003: Remove the BeginSaveFile and BeginDownload methods from ResourceDispatcherHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix browser test redness by ensuring that the ResourceDispatcherHostDelegate is notified in CreateR… Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index a1b1f7b1df531921974518a8956c6588f6e0651d..098f6d97bae98a37f063495b98e607868ce29ff8 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -25,6 +25,7 @@
#include "content/browser/browser_thread_impl.h"
#include "content/browser/cert_store_impl.h"
#include "content/browser/child_process_security_policy_impl.h"
+#include "content/browser/download/download_manager_impl.h"
#include "content/browser/frame_host/navigation_request_info.h"
#include "content/browser/loader/cross_site_resource_handler.h"
#include "content/browser/loader/detachable_resource_handler.h"
@@ -869,6 +870,7 @@ class ResourceDispatcherHostTest : public testing::TestWithParam<TestConfig>,
request_context->set_job_factory(job_factory_.get());
request_context->set_network_delegate(&network_delegate_);
host_.cert_store_for_testing_ = &mock_cert_store_;
+ DownloadManagerImpl::ResourceDispatcherHostCreated();
}
// IPC::Sender implementation
@@ -1235,6 +1237,8 @@ void ResourceDispatcherHostTest::MakeTestRequestWithPriorityAndRenderFrame(
host_.OnMessageReceived(msg, filter_.get());
}
+// TODO(ananta)
+// Move this test into the download tests.
void ResourceDispatcherHostTest::MakeWebContentsAssociatedDownloadRequest(
int request_id,
const GURL& url) {
@@ -1242,12 +1246,12 @@ void ResourceDispatcherHostTest::MakeWebContentsAssociatedDownloadRequest(
browser_context_->GetResourceContext()->GetRequestContext();
std::unique_ptr<net::URLRequest> request(
request_context->CreateRequest(url, net::DEFAULT_PRIORITY, NULL));
- host_.BeginDownload(std::move(request), Referrer(),
- false, // is_content_initiated
- browser_context_->GetResourceContext(),
- web_contents_->GetRenderProcessHost()->GetID(),
- web_contents_->GetRoutingID(),
- web_contents_->GetMainFrame()->GetRoutingID(), false);
+ DownloadManagerImpl::BeginDownloadRequest(
+ std::move(request), Referrer(), browser_context_->GetResourceContext(),
+ false, // is_content_initiated
+ web_contents_->GetRenderProcessHost()->GetID(),
+ web_contents_->GetRoutingID(),
+ web_contents_->GetMainFrame()->GetRoutingID(), false);
}
void ResourceDispatcherHostTest::CancelRequest(int request_id) {

Powered by Google App Engine
This is Rietveld 408576698