Remove the BeginSaveFile and BeginDownload methods from ResourceDispatcherHostImpl

content/browser/download/download_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_resource_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 88 matching lines @@
 
 void DeleteOnUIThread(
     std::unique_ptr<DownloadResourceHandler::DownloadTabInfo> tab_info) {}
 
 }  // namespace
 
 DownloadResourceHandler::DownloadResourceHandler(net::URLRequest* request)
     : ResourceHandler(request),
       tab_info_(new DownloadTabInfo()),
       core_(request, this) {
-  // Do UI thread initialization for tab_info_ asap after
-  // DownloadResourceHandler creation since the tab could be navigated
-  // before StartOnUIThread gets called.  This is safe because deletion
-  // will occur via PostTask() as well, which will serialized behind this
-  // PostTask()
-  const ResourceRequestInfoImpl* request_info = GetRequestInfo();
-  BrowserThread::PostTask(
-      BrowserThread::UI, FROM_HERE,
-      base::Bind(
-          &InitializeDownloadTabInfoOnUIThread,
-          DownloadRequestHandle(AsWeakPtr(),
-                                request_info->GetWebContentsGetterForRequest()),
-          tab_info_.get()));
 }
 
 DownloadResourceHandler::~DownloadResourceHandler() {
   if (tab_info_) {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&DeleteOnUIThread, base::Passed(&tab_info_)));
   }
 }
 
 bool DownloadResourceHandler::OnRequestRedirected(
     const net::RedirectInfo& redirect_info,
     ResourceResponse* response,
     bool* defer) {
   return core_.OnRequestRedirected();
 }
 
 // Send the download creation information to the download thread.
 bool DownloadResourceHandler::OnResponseStarted(
     ResourceResponse* response,
     bool* defer) {
   // The MIME type in ResourceResponse is the product of
   // MimeTypeResourceHandler.
   return core_.OnResponseStarted(response->head.mime_type);
 }
 
 bool DownloadResourceHandler::OnWillStart(const GURL& url, bool* defer) {
+  // Do UI thread initialization for tab_info_ asap after

[svaldez, 2016/08/19 17:05:14]

Comment should be updated.

[ananta, 2016/08/19 19:02:14]

Done.

+  // DownloadResourceHandler creation since the tab could be navigated
+  // before StartOnUIThread gets called.  This is safe because deletion
+  // will occur via PostTask() as well, which will serialized behind this
+  // PostTask()
+  const ResourceRequestInfoImpl* request_info = GetRequestInfo();
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      base::Bind(
+          &InitializeDownloadTabInfoOnUIThread,
+          DownloadRequestHandle(AsWeakPtr(),
+                                request_info->GetWebContentsGetterForRequest()),
+          tab_info_.get()));
   return true;
 }
 
 // Create a new buffer, which will be handed to the download thread for file
 // writing and deletion.
 bool DownloadResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
                                          int* buf_size,
                                          int min_size) {
   return core_.OnWillRead(buf, buf_size, min_size);
 }
@@ skipping 83 matching lines @@
                             " }",
                             request() ?
                                 request()->url().spec().c_str() :
                                 "<NULL request>",
                             info->GetChildID(),
                             info->GetRequestID(),
                             info->GetRouteID());
 }
 
 }  // namespace content