Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2251643002: Make MemoryCoordinator garbage collected (Closed)

Created:
4 years, 4 months ago by bashi
Modified:
4 years, 4 months ago
Reviewers:
keishi, haraken, tasak
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MemoryCoordinator garbage collected To make sure MemoryCoordinator::trace() is called.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 1 chunk +4 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (6 generated)
bashi
PTAL? Sakamoto-san kindly told me that MemoryCoordinator::trace() won't get called unless it's on heap.
4 years, 4 months ago (2016-08-16 06:57:26 UTC) #4
keishi
https://codereview.chromium.org/2251643002/diff/1/third_party/WebKit/Source/platform/MemoryCoordinator.cpp File third_party/WebKit/Source/platform/MemoryCoordinator.cpp (right): https://codereview.chromium.org/2251643002/diff/1/third_party/WebKit/Source/platform/MemoryCoordinator.cpp#newcode23 third_party/WebKit/Source/platform/MemoryCoordinator.cpp:23: instance = new Persistent<MemoryCoordinator>(new MemoryCoordinator); This may be shorter ...
4 years, 4 months ago (2016-08-16 08:41:35 UTC) #7
haraken
4 years, 4 months ago (2016-08-16 11:33:47 UTC) #8
LGTM with keishi@'s comment addressed.

Powered by Google App Engine
This is Rietveld 408576698