content/browser/service_worker/service_worker_register_job.cc - Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unused has_fetch_handler_ in service_worker_version.h Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc ('k') | content/browser/service_worker/service_worker_registration_unittest.cc » ('j') | content/browser/service_worker/service_worker_version.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 33fa4e88c28c22cff9436c65a01160aa0f4b3132..97d509cd4bd89e327041ca17c71fbc17b385da1c 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -469,7 +469,10 @@ void ServiceWorkerRegisterJob::OnInstallFinished(

SetPhase(STORE);

DCHECK(!registration()->last_update_check().is_null());

- new_version()->set_has_fetch_handler(has_fetch_handler);

+ new_version()->set_fetch_handler_status(

+ has_fetch_handler

+ ? ServiceWorkerVersion::FetchHandlerStatus::EXISTS

+ : ServiceWorkerVersion::FetchHandlerStatus::DOES_NOT_EXIST);

context_->storage()->StoreRegistration(

registration(),

new_version(),