content/browser/service_worker/service_worker_storage.cc - Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_browsertest.cc ('K') | « content/browser/service_worker/service_worker_request_handler_unittest.cc ('k') | content/browser/service_worker/service_worker_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.cc

diff --git a/content/browser/service_worker/service_worker_storage.cc b/content/browser/service_worker/service_worker_storage.cc

index 6c2d57ab5cfc1f8be429d8d3593a495c77b449b3..62d444415b8642dcbb65e71bf3e593b685781314 100644

--- a/content/browser/service_worker/service_worker_storage.cc

+++ b/content/browser/service_worker/service_worker_storage.cc

@@ -398,7 +398,7 @@ void ServiceWorkerStorage::StoreRegistration(

data.registration_id = registration->id();

data.scope = registration->pattern();

data.script = version->script_url();

- data.has_fetch_handler = version->has_fetch_handler();

+ data.has_fetch_handler = version->has_fetch_handler().value();

data.version_id = version->version_id();

data.last_update_check = registration->last_update_check();

data.is_active = (version == registration->active_version());

@@ -1243,12 +1243,12 @@ ServiceWorkerStorage::GetOrCreateRegistration(

if (!version) {

version = new ServiceWorkerVersion(

registration.get(), data.script, data.version_id, context_);

+ version->set_has_fetch_handler(data.has_fetch_handler);

version->SetStatus(data.is_active ?

ServiceWorkerVersion::ACTIVATED : ServiceWorkerVersion::INSTALLED);

version->script_cache_map()->SetResources(resources);

version->set_foreign_fetch_scopes(data.foreign_fetch_scopes);

version->set_foreign_fetch_origins(data.foreign_fetch_origins);

- version->set_has_fetch_handler(data.has_fetch_handler);

}

if (version->status() == ServiceWorkerVersion::ACTIVATED)