content/browser/service_worker/service_worker_job_unittest.cc - Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_browsertest.cc ('K') | « content/browser/service_worker/service_worker_handle_unittest.cc ('k') | content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index 14729cbc103eba71f56d6e75e3866988f4e69a80..c2579bbfa174d2edd15c7c6171377099db1aaeb4 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -657,6 +657,7 @@ TEST_F(ServiceWorkerJobTest, UnregisterWaitingSetsRedundant) {

base::RunLoop().RunUntilIdle();

ASSERT_EQ(SERVICE_WORKER_OK, status);

+ version->set_has_fetch_handler(true);

version->SetStatus(ServiceWorkerVersion::INSTALLED);

registration->SetWaitingVersion(version);

EXPECT_EQ(EmbeddedWorkerStatus::RUNNING, version->running_status());

@@ -1593,13 +1594,13 @@ TEST_F(ServiceWorkerJobTest, HasFetchHandler) {

helper->set_has_fetch_handler(true);

RunRegisterJob(pattern, script);

registration = FindRegistrationForPattern(pattern);

- EXPECT_TRUE(registration->active_version()->has_fetch_handler());

+ EXPECT_TRUE(registration->active_version()->has_fetch_handler().value());

RunUnregisterJob(pattern);

helper->set_has_fetch_handler(false);

RunRegisterJob(pattern, script);

registration = FindRegistrationForPattern(pattern);

- EXPECT_FALSE(registration->active_version()->has_fetch_handler());

+ EXPECT_FALSE(registration->active_version()->has_fetch_handler().value());

RunUnregisterJob(pattern);

}