content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_browsertest.cc ('K') | « content/browser/service_worker/service_worker_browsertest.cc ('k') | content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index 6312b57b09bc3c6d5e4a54f71489cc3e338156e3..c64dd8aeaa76960e0b2b1ea27f63abb97163c779 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -33,7 +33,7 @@ bool MaybeForwardToServiceWorker(ServiceWorkerURLRequestJob* job,

const ServiceWorkerVersion* version) {

DCHECK(job);

DCHECK(version);

- if (version->has_fetch_handler()) {

+ if (version->has_fetch_handler().value()) {

job->ForwardToServiceWorker();

return true;

}

@@ -281,7 +281,8 @@ void ServiceWorkerControlleeRequestHandler::

}

ServiceWorkerMetrics::CountControlledPageLoad(

- stripped_url_, active_version->has_fetch_handler(), is_main_frame_load_);

+ stripped_url_, active_version->has_fetch_handler().value(),

+ is_main_frame_load_);

bool is_forwarded =

MaybeForwardToServiceWorker(job_.get(), active_version.get());

@@ -311,7 +312,7 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(

}

ServiceWorkerMetrics::CountControlledPageLoad(

- stripped_url_, version->has_fetch_handler(), is_main_frame_load_);

+ stripped_url_, version->has_fetch_handler().value(), is_main_frame_load_);

provider_host_->AssociateRegistration(registration,

false /* notify_controllerchange */);