content/browser/service_worker/service_worker_registration_unittest.cc - Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 2251633002: Use tri-state enum for the existence of Fetch Handler in ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/status/existence/ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 654a434ca4585ef84956dec0aeeb7d498b09a1c6..75272826755c2ea028569669a04cb85a27297a40 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -199,6 +199,8 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {

scoped_refptr<ServiceWorkerVersion> version_1 = new ServiceWorkerVersion(

registration_.get(), kScript, storage()->NewVersionId(),

context()->AsWeakPtr());

+ version_1->set_fetch_handler_existence(

+ ServiceWorkerVersion::FetchHandlerExistence::EXISTS);

registration_->SetActiveVersion(version_1);

version_1->SetStatus(ServiceWorkerVersion::ACTIVATED);

@@ -230,6 +232,8 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {

scoped_refptr<ServiceWorkerVersion> version_2 = new ServiceWorkerVersion(

registration_.get(), kScript, storage()->NewVersionId(),

context()->AsWeakPtr());

+ version_2->set_fetch_handler_existence(

+ ServiceWorkerVersion::FetchHandlerExistence::EXISTS);

registration_->SetWaitingVersion(version_2);

version_2->SetStatus(ServiceWorkerVersion::INSTALLED);