Source/core/dom/Element.cpp - Issue 225163004: Element::focus() should acquire the reference of LocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 225163004: Element::focus() should acquire the reference of LocalFrame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index b69bcd30d4d81d43c05ed5ca03605f1a7d3ff879..7f4bdbdf594e2dc276aa7af299328ff5144ac829 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2154,7 +2154,8 @@ void Element::focus(bool restorePreviousSelection, FocusType type)

void Element::updateFocusAppearance(bool /*restorePreviousSelection*/)

{

if (isRootEditableElement()) {

- LocalFrame* frame = document().frame();

+ // Taking the ownership since setSelection() may release the last reference to |frame|.

+ RefPtr<LocalFrame> frame(document().frame());

if (!frame)

return;