Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: go/src/infra/appengine/test-results/frontend/builders.go

Issue 2251623002: test-results: Get handler cleanup (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@x_3
Patch Set: (Rebase) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | go/src/infra/appengine/test-results/frontend/get.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/appengine/test-results/frontend/builders.go
diff --git a/go/src/infra/appengine/test-results/frontend/builders.go b/go/src/infra/appengine/test-results/frontend/builders.go
index d85e04fa573229c0828d28e60cf9353abd11eee8..40f1849c92bb70ed14f4b6d88be677902adfe420 100644
--- a/go/src/infra/appengine/test-results/frontend/builders.go
+++ b/go/src/infra/appengine/test-results/frontend/builders.go
@@ -106,8 +106,8 @@ func GetBuilders(ctx *router.Context) {
}
var out io.Reader = bytes.NewReader(res)
- if callback := r.FormValue("callback"); callback != "" {
- out = wrapCallback(out, callback)
+ if c := r.FormValue("callback"); callbackNameRx.MatchString(c) {
+ out = wrapCallback(out, c)
}
n, err := io.Copy(w, out)
« no previous file with comments | « no previous file | go/src/infra/appengine/test-results/frontend/get.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698