Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251603004:
Fix compilation on BSD platforms (Closed)
DescriptionFix compilation on BSD platforms
I could only test this with FreeBSD and OSX
(on the Node.js CI).
I don't know if the fix is correct for other BSD platforms.
Committed: https://crrev.com/bcac03e69bba48218671768e7fea85ca7246d3c0
Cr-Commit-Position: refs/heads/master@{#38905}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Fix compilation on BSD platforms BUG= ========== to ========== Fix compilation on BSD platforms I could only test this with FreeBSD (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ==========
mic.besace@gmail.com changed reviewers: + lpy@chromium.org
lpy@chromium.org changed reviewers: + yangguo@chromium.org
LGTM. Please keep the description 80-characters wide. + Yang@, stamp?
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix compilation on BSD platforms I could only test this with FreeBSD (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ========== to ========== Fix compilation on BSD platforms I could only test this with FreeBSD (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ==========
Friendly ping :)
jkummerow@chromium.org changed reviewers: + jkummerow@chromium.org
LGTM if you're sure this doesn't break OSX. (Yang is OOO.)
Description was changed from ========== Fix compilation on BSD platforms I could only test this with FreeBSD (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ========== to ========== Fix compilation on BSD platforms I could only test this with FreeBSD and OSX (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ==========
The CQ bit was checked by mic.besace@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix compilation on BSD platforms I could only test this with FreeBSD and OSX (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ========== to ========== Fix compilation on BSD platforms I could only test this with FreeBSD and OSX (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix compilation on BSD platforms I could only test this with FreeBSD and OSX (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. ========== to ========== Fix compilation on BSD platforms I could only test this with FreeBSD and OSX (on the Node.js CI). I don't know if the fix is correct for other BSD platforms. Committed: https://crrev.com/bcac03e69bba48218671768e7fea85ca7246d3c0 Cr-Commit-Position: refs/heads/master@{#38905} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bcac03e69bba48218671768e7fea85ca7246d3c0 Cr-Commit-Position: refs/heads/master@{#38905} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
