Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2251523002: Delete unused IDS_OPTIONS_SETTINGS_LANGUAGES_ strings (Closed)

Created:
4 years, 4 months ago by Greg Levin
Modified:
4 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused IDS_OPTIONS_SETTINGS_LANGUAGES_ strings BUG=350660 TESTS=Absence of these strings doesn't break any builds or tools Committed: https://crrev.com/e32082da5a1273379a34e922e59191243047915f Cr-Commit-Position: refs/heads/master@{#413381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -556 lines) Patch
M chrome/app/chromeos_strings.grdp View 3 chunks +0 lines, -556 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Greg Levin
oshima@- Not sure who'd be the right reviewer for just deleting strings, so picking you ...
4 years, 4 months ago (2016-08-16 14:23:04 UTC) #6
oshima
lgtm
4 years, 4 months ago (2016-08-19 19:37:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251523002/1
4 years, 4 months ago (2016-08-21 22:19:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 22:59:53 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 23:01:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e32082da5a1273379a34e922e59191243047915f
Cr-Commit-Position: refs/heads/master@{#413381}

Powered by Google App Engine
This is Rietveld 408576698