Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2251503002: [Bootstrapping] Update the slave device's network connectivity status correctly. (Closed)

Created:
4 years, 4 months ago by xdai1
Modified:
4 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Bootstrapping] Update the slave device's network connectivity status correctly. BUG=637961 Committed: https://crrev.com/cde6092ba11fb99109c6cb898888e7933ffbfe22 Cr-Commit-Position: refs/heads/master@{#412082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
xdai1
achuith@, could you help review this CL please? Thanks!
4 years, 4 months ago (2016-08-15 21:59:33 UTC) #2
achuithb
lgtm
4 years, 4 months ago (2016-08-15 22:16:28 UTC) #5
xdai1
On 2016/08/15 22:16:28, achuithb wrote: > lgtm Thanks!
4 years, 4 months ago (2016-08-15 22:26:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251503002/1
4 years, 4 months ago (2016-08-15 22:53:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 22:58:13 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 23:00:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cde6092ba11fb99109c6cb898888e7933ffbfe22
Cr-Commit-Position: refs/heads/master@{#412082}

Powered by Google App Engine
This is Rietveld 408576698