third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl - Issue 2251493003: Adding nullability support to ImageBitmapRenderingContext.transferImageBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

Issue 2251493003: Adding nullability support to ImageBitmapRenderingContext.transferImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp ('K') | « third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

diff --git a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

index 3689a4177f40dd18aca73c3463df40c769475f54..33a62fff127318efdd7aa51bb96177d7a6d1fc3c 100644

--- a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

+++ b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.idl

@@ -9,5 +9,5 @@

// back-reference to the canvas

readonly attribute HTMLCanvasElement canvas;

- void transferFromImageBitmap(ImageBitmap bitmap);

+ void transferFromImageBitmap([EnforceRange] ImageBitmap? bitmap);

Justin Novosad 2016/08/16 19:38:55 Why EnforceRange? I don't even understand what th

zakerinasab 2016/08/16 20:34:49 Corrected.

};