Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp

Issue 2251493003: Adding nullability support to ImageBitmapRenderingContext.transferImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments from patch set 3. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/imagebitmap/ImageBitmapRenderingContext.h" 5 #include "modules/imagebitmap/ImageBitmapRenderingContext.h"
6 6
7 #include "bindings/modules/v8/RenderingContext.h" 7 #include "bindings/modules/v8/RenderingContext.h"
8 #include "core/frame/ImageBitmap.h" 8 #include "core/frame/ImageBitmap.h"
9 #include "platform/graphics/GraphicsContext.h" 9 #include "platform/graphics/GraphicsContext.h"
10 #include "platform/graphics/StaticBitmapImage.h" 10 #include "platform/graphics/StaticBitmapImage.h"
11 #include "third_party/skia/include/core/SkImage.h" 11 #include "third_party/skia/include/core/SkImage.h"
12 #include "third_party/skia/include/core/SkSurface.h" 12 #include "third_party/skia/include/core/SkSurface.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 ImageBitmapRenderingContext::ImageBitmapRenderingContext(HTMLCanvasElement* canv as, CanvasContextCreationAttributes attrs, Document& document) 16 ImageBitmapRenderingContext::ImageBitmapRenderingContext(HTMLCanvasElement* canv as, CanvasContextCreationAttributes attrs, Document& document)
17 : CanvasRenderingContext(canvas) 17 : CanvasRenderingContext(canvas)
18 , m_hasAlpha(attrs.alpha()) 18 , m_hasAlpha(attrs.alpha())
19 { } 19 { }
20 20
21 ImageBitmapRenderingContext::~ImageBitmapRenderingContext() { } 21 ImageBitmapRenderingContext::~ImageBitmapRenderingContext() { }
22 22
23 void ImageBitmapRenderingContext::setCanvasGetContextResult(RenderingContext& re sult) 23 void ImageBitmapRenderingContext::setCanvasGetContextResult(RenderingContext& re sult)
24 { 24 {
25 result.setImageBitmapRenderingContext(this); 25 result.setImageBitmapRenderingContext(this);
26 } 26 }
27 27
28 void ImageBitmapRenderingContext::transferFromImageBitmap(ImageBitmap* imageBitm ap) 28 void ImageBitmapRenderingContext::transferFromImageBitmap(ImageBitmap* imageBitm ap)
29 { 29 {
30 if (!imageBitmap) {
31 m_image.release();
32 return;
33 }
34
30 m_image = imageBitmap->bitmapImage(); 35 m_image = imageBitmap->bitmapImage();
31 if (!m_image) 36 if (!m_image)
32 return; 37 return;
33 38
34 RefPtr<SkImage> skImage = m_image->imageForCurrentFrame(); 39 RefPtr<SkImage> skImage = m_image->imageForCurrentFrame();
35 if (skImage->isTextureBacked()) { 40 if (skImage->isTextureBacked()) {
36 // TODO(junov): crbug.com/585607 Eliminate this readback and use an Exte rnalTextureLayer 41 // TODO(junov): crbug.com/585607 Eliminate this readback and use an Exte rnalTextureLayer
37 sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(skImage->width (), skImage->height()); 42 sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul(skImage->width (), skImage->height());
38 if (!surface) { 43 if (!surface) {
39 // silent failure 44 // silent failure
(...skipping 24 matching lines...) Expand all
64 return nullptr; 69 return nullptr;
65 return new ImageBitmapRenderingContext(canvas, attrs, document); 70 return new ImageBitmapRenderingContext(canvas, attrs, document);
66 } 71 }
67 72
68 void ImageBitmapRenderingContext::stop() 73 void ImageBitmapRenderingContext::stop()
69 { 74 {
70 m_image.clear(); 75 m_image.clear();
71 } 76 }
72 77
73 } // blink 78 } // blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698