third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html - Issue 2251493003: Adding nullability support to ImageBitmapRenderingContext.transferImageBitmap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability.html

Issue 2251493003: Adding nullability support to ImageBitmapRenderingContext.transferImageBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Layout tests and code update for resetting the canvas Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/canvas/imagebitmap/transferFromImageBitmap-nullability-harness.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <canvas id = 'dstCanvas' width='100' height='100'></canvas>	2 <canvas id = 'dstCanvas' width='100' height='100'></canvas>

3 <script>	3 <script>

4 if (window.testRunner) {	4 if (window.testRunner) {

5 testRunner.waitUntilDone();	5 testRunner.waitUntilDone();

6 }	6 }

7 var srcCanvas = document.createElement('canvas');	7 var srcCanvas = document.createElement('canvas');

8 srcCanvas.width = srcCanvas.height = 100;	8 srcCanvas.width = srcCanvas.height = 100;

9 var ctx = srcCanvas.getContext('2d');	9 var ctx = srcCanvas.getContext('2d');

10 ctx.fillStyle = 'green';	10 ctx.fillStyle = 'green';

11 ctx.fillRect(0, 0, 100, 100);	11 ctx.fillRect(0, 0, 100, 100);

12 createImageBitmap(srcCanvas).then(consumeImageBitmap)	12 createImageBitmap(srcCanvas).then(consumeImageBitmap)

13	13

14 function consumeImageBitmap(image) {	14 function consumeImageBitmap(image) {

15 var dstCanvas = document.getElementById('dstCanvas');	15 var dstCanvas = document.getElementById('dstCanvas');

16 var dstCtx = dstCanvas.getContext('bitmaprenderer');	16 var dstCtx = dstCanvas.getContext('bitmaprenderer');

17 dstCtx.transferFromImageBitmap(image);	17 dstCtx.transferFromImageBitmap(image);

	18 dstCtx.transferFromImageBitmap(null);
	Justin Novosad 2016/08/18 15:27:27 This test seems redundant with the other one. Tes This test seems redundant with the other one. Testharness.js tests are preferable. You should get the other test to work and eliminate this one.
18 if (window.testRunner) {	19 if (window.testRunner) {

19 testRunner.notifyDone();	20 testRunner.notifyDone();

20 }	21 }

21 }	22 }

22 </script>	23 </script>

	24

OLD	NEW