Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Issue 2251493002: arc: Fix crash on Arc window close. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit_tests fixed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
index 2a5b03a16c4c06ab3ff924912fec633ceb09b5bf..ee862616618e6e30be65bd7c6f2b07a9dc149364 100644
--- a/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
@@ -21,8 +21,10 @@
#include "chrome/browser/ui/ash/launcher/extension_launcher_context_menu.h"
#include "chrome/test/base/testing_profile.h"
#include "components/arc/test/fake_app_instance.h"
+#include "components/exo/shell_surface.h"
#include "components/prefs/pref_service.h"
#include "ui/aura/window_event_dispatcher.h"
+#include "ui/views/widget/widget.h"
class LauncherContextMenuTest : public ash::test::AshTestBase {
protected:
@@ -65,6 +67,18 @@ class LauncherContextMenuTest : public ash::test::AshTestBase {
return LauncherContextMenu::Create(controller_.get(), item, GetWmShelf());
}
+ // Creates app window and set optional Arc application id.
+ views::Widget* CreateArcWindow(std::string& window_app_id) {
+ views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
+ views::Widget* widget = new views::Widget();
+ widget->Init(params);
+ widget->Show();
+ widget->Activate();
+ exo::ShellSurface::SetApplicationId(widget->GetNativeWindow(),
+ &window_app_id);
+ return widget;
+ }
+
ArcAppTest& arc_test() { return arc_test_; }
Profile* profile() { return profile_.get(); }
@@ -195,6 +209,8 @@ TEST_F(LauncherContextMenuTest, ArcLauncherContextMenuItemCheck) {
menu->IsCommandIdEnabled(LauncherContextMenu::MENU_CHANGE_WALLPAPER));
// Arc app is running.
+ std::string window_app_id1("org.chromium.arc.1");
+ CreateArcWindow(window_app_id1);
arc_test().app_instance()->SendTaskCreated(1, arc_test().fake_apps()[0]);
menu.reset(new ArcLauncherContextMenu(controller(), &item, wm_shelf));
@@ -207,6 +223,8 @@ TEST_F(LauncherContextMenuTest, ArcLauncherContextMenuItemCheck) {
// Arc non-launchable app is running.
const std::string app_id2 = ArcAppTest::GetAppId(arc_test().fake_apps()[1]);
+ std::string window_app_id2("org.chromium.arc.2");
+ CreateArcWindow(window_app_id2);
arc_test().app_instance()->SendTaskCreated(2, arc_test().fake_apps()[1]);
item.id = controller()->GetShelfIDForAppID(app_id2);
ASSERT_TRUE(item.id);
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698