Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2251483002: Don't record post-quantum stats if MITM. (Closed)

Created:
4 years, 4 months ago by mab
Modified:
4 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, estark
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't record post-quantum stats if MITM. If something other than Google is terminating the TLS connection, then we shouldn't expect the post-quantum ciphersuites to be present. So, exclude such connections from the statistics. (Suggestion from estark--thanks!) BUG=626363 Committed: https://crrev.com/537c7b14339a51c7c07b496a0ed05ca3a010bbb2 Cr-Commit-Position: refs/heads/master@{#412100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/socket/ssl_client_socket_pool.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mab
4 years, 4 months ago (2016-08-15 21:18:02 UTC) #3
davidben
lgtm
4 years, 4 months ago (2016-08-15 21:19:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251483002/1
4 years, 4 months ago (2016-08-15 22:48:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 23:47:56 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 23:50:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/537c7b14339a51c7c07b496a0ed05ca3a010bbb2
Cr-Commit-Position: refs/heads/master@{#412100}

Powered by Google App Engine
This is Rietveld 408576698