Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2251463002: Adding test to avoid memory leak when autoplayed video never become visible (Closed)

Created:
4 years, 4 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding test to avoid memory leak when autoplayed video never become visible BUG=627539 Committed: https://crrev.com/339881fcea518c6f7ff6e1a04a2a5f40e26de850 Cr-Commit-Position: refs/heads/master@{#412210}

Patch Set 1 #

Patch Set 2 : Adding test to avoid memory leak when autoplayed video never become visible #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/media/autoplay-never-visible.html View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhiqiang Zhang (Slow)
PTAL. I tried the leak on trunk today. It seems the flaky leak is much ...
4 years, 4 months ago (2016-08-15 20:13:33 UTC) #2
mlamouri (slow - plz ping)
lgtm Is the leak fixed then?
4 years, 4 months ago (2016-08-16 09:07:13 UTC) #3
Zhiqiang Zhang (Slow)
On 2016/08/16 09:07:13, Mounir Lamouri wrote: > lgtm > > Is the leak fixed then? ...
4 years, 4 months ago (2016-08-16 09:33:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251463002/20001
4 years, 4 months ago (2016-08-16 10:53:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 10:57:13 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 10:58:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/339881fcea518c6f7ff6e1a04a2a5f40e26de850
Cr-Commit-Position: refs/heads/master@{#412210}

Powered by Google App Engine
This is Rietveld 408576698