Only create widgets if really needed.

Only create widgets if really needed.

Currently the GetWidget call will create a backing widget for a control behind
the scenes if it doesn't exist. This can cause more work to be done then needed
as we may need to create the page and any supporting structures. This created
structure will then be torn down as we don't need it anymore once we're done
with the widget.

For the instances where setting the value on the widget will have no effect (as
we'll destroy it anyway) we can tell GetWidget() to not create the widget and
return without doing any work.

BUG=chromium:632709
Committed: https://pdfium.googlesource.com/pdfium/+/ef523dd36aea991084b8b934df846014a5c09c6f

[dsinclair, 2016-08-15 19:51:07]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[dsinclair, 2016-08-15 19:51:08]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[commit-bot: I haz the power, 2016-08-15 19:51:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-08-15 19:51:09]

PTAL. This allows me to load the testfocus2 file inside an ASAN chrome build
without issue.

[commit-bot: I haz the power, 2016-08-15 20:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:08:00]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-15 20:09:08]

lgtm

[dsinclair, 2016-08-15 20:09:39]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-08-15 20:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:10:06]

Description was changed from

==========
Only create widgets if really needed.

Currently the GetWidget call will create a backing widget for a control behind
the scenes if it doesn't exist. This can cause more work to be done then needed
as we may need to create the page and any supporting structures. This created
structure will then be torn down as we don't need it anymore once we're done
with the widget.

For the instances where setting the value on the widget will have no effect (as
we'll destroy it anyway) we can tell GetWidget() to not create the widget and
return without doing any work.

BUG=pdfium:632709
==========

to

==========
Only create widgets if really needed.

Currently the GetWidget call will create a backing widget for a control behind
the scenes if it doesn't exist. This can cause more work to be done then needed
as we may need to create the page and any supporting structures. This created
structure will then be torn down as we don't need it anymore once we're done
with the widget.

For the instances where setting the value on the widget will have no effect (as
we'll destroy it anyway) we can tell GetWidget() to not create the widget and
return without doing any work.

BUG=pdfium:632709

Committed:
https://pdfium.googlesource.com/pdfium/+/ef523dd36aea991084b8b934df846014a5c0...
==========

[commit-bot: I haz the power, 2016-08-15 20:10:07]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ef523dd36aea991084b8b934df846014a5c0...

[Lei Zhang, 2016-11-03 15:33:40]

BTW, the BUG= line is wrong.

[dsinclair, 2016-11-03 18:21:34]

Description was changed from

==========
Only create widgets if really needed.

Currently the GetWidget call will create a backing widget for a control behind
the scenes if it doesn't exist. This can cause more work to be done then needed
as we may need to create the page and any supporting structures. This created
structure will then be torn down as we don't need it anymore once we're done
with the widget.

For the instances where setting the value on the widget will have no effect (as
we'll destroy it anyway) we can tell GetWidget() to not create the widget and
return without doing any work.

BUG=pdfium:632709

Committed:
https://pdfium.googlesource.com/pdfium/+/ef523dd36aea991084b8b934df846014a5c0...
==========

to

==========
Only create widgets if really needed.

Currently the GetWidget call will create a backing widget for a control behind
the scenes if it doesn't exist. This can cause more work to be done then needed
as we may need to create the page and any supporting structures. This created
structure will then be torn down as we don't need it anymore once we're done
with the widget.

For the instances where setting the value on the widget will have no effect (as
we'll destroy it anyway) we can tell GetWidget() to not create the widget and
return without doing any work.

BUG=chromium:632709

Committed:
https://pdfium.googlesource.com/pdfium/+/ef523dd36aea991084b8b934df846014a5c0...
==========