Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2251413004: LogDog: Properly emit Butler stream magic. (Closed)

Created:
4 years, 4 months ago by dnj
Modified:
4 years, 4 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

LogDog: Properly emit Butler stream magic. The LogDog Butler protocol was not properly implemented: it was missing the magic byte sequence that must precede the exchange. Add that sequence to the stream implementation. BUG=chromium:628770 TEST=local - Ran with live Butler instance, observed successful stream negotiation. Committed: https://github.com/luci/luci-py/commit/999aff1abdcaf37cfed37f7451ea0a2f54a7fdea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M client/libs/logdog/stream.py View 4 chunks +22 lines, -1 line 0 comments Download
M client/libs/logdog/tests/stream_test.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 4 months ago (2016-08-19 02:42:57 UTC) #2
martiniss
lgtm
4 years, 4 months ago (2016-08-19 17:24:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251413004/1
4 years, 4 months ago (2016-08-19 20:38:06 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 21:11:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/999aff1abdcaf37cfed37f7451ea0a2f54a7fdea

Powered by Google App Engine
This is Rietveld 408576698