Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M

Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M

Due to crbug.com/625188 fix NetworkHandles in the NetLog were unreadable,
fix them to be readable again.

R=xunjieli
BUG=625188
Committed: https://crrev.com/eef27f6a445e0d16821f3ceebf73ca1a6d083698
Cr-Commit-Position: refs/heads/master@{#413133}

[pauljensen, 2016-08-18 14:52:26]

Helen, PTAL, thank you!

[xunjieli, 2016-08-18 16:13:16]

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
net/base/logging_network_change_observer.cc:56:
base::IntToString(HumanReadableNetworkHandle(active_network)),
Why does ">>32" make network handle human readable? 

Can we use base::Int64ToString instead and remove the demungling? (since the
handles are 64bits?)

[pauljensen, 2016-08-18 16:16:49]

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
net/base/logging_network_change_observer.cc:56:
base::IntToString(HumanReadableNetworkHandle(active_network)),
On 2016/08/18 16:13:16, xunjieli wrote:
> Why does ">>32" make network handle human readable? 
> 
> Can we use base::Int64ToString instead and remove the demungling? (since the
> handles are 64bits?) 

">> 32" makes it readable because it undoes the munging of
Network.getNetworkHandle(), " << 32 | 0xfacade":
http://androidxref.com/6.0.1_r10/xref/frameworks/base/core/java/android/net/N...

[xunjieli, 2016-08-18 17:15:17]

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
net/base/logging_network_change_observer.cc:25: // On Marshmallow, demunge the
NetID to undo munging done in java
Could you add a comment here that the NetID's lower 32 bit is 0xfacade? and
include the link that you just gave me?

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
net/base/logging_network_change_observer.cc:56:
base::IntToString(HumanReadableNetworkHandle(active_network)),
On 2016/08/18 16:16:49, pauljensen wrote:
> On 2016/08/18 16:13:16, xunjieli wrote:
> > Why does ">>32" make network handle human readable? 
> > 
> > Can we use base::Int64ToString instead and remove the demungling? (since the
> > handles are 64bits?) 
> 
> ">> 32" makes it readable because it undoes the munging of
> Network.getNetworkHandle(), " << 32 | 0xfacade":
>
http://androidxref.com/6.0.1_r10/xref/frameworks/base/core/java/android/net/N...

Makes sense. I forgot about the 0xfacade part.

[pauljensen, 2016-08-19 11:57:48]

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
File net/base/logging_network_change_observer.cc (right):

https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_ch...
net/base/logging_network_change_observer.cc:25: // On Marshmallow, demunge the
NetID to undo munging done in java
On 2016/08/18 17:15:17, xunjieli(OOO-8.21-8.26) wrote:
> Could you add a comment here that the NetID's lower 32 bit is 0xfacade? and
> include the link that you just gave me?

Done.

[xunjieli, 2016-08-19 11:59:32]

lgtm

[pauljensen, 2016-08-19 12:00:40]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-08-19 12:01:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 14:07:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 14:10:05]

Description was changed from

==========
Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M

Due to crbug.com/625188 fix NetworkHandles in the NetLog were unreadable,
fix them to be readable again.

R=xunjieli
BUG=625188
==========

to

==========
Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M

Due to crbug.com/625188 fix NetworkHandles in the NetLog were unreadable,
fix them to be readable again.

R=xunjieli
BUG=625188

Committed: https://crrev.com/eef27f6a445e0d16821f3ceebf73ca1a6d083698
Cr-Commit-Position: refs/heads/master@{#413133}
==========

[commit-bot: I haz the power, 2016-08-19 14:10:06]

Patchset 2 (id:??) landed as
https://crrev.com/eef27f6a445e0d16821f3ceebf73ca1a6d083698
Cr-Commit-Position: refs/heads/master@{#413133}