Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2251413003: Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M (Closed)

Created:
4 years, 4 months ago by pauljensen
Modified:
4 years, 4 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NetworkChangeNotifier NetworkHandles readable in NetLog on Android M Due to crbug.com/625188 fix NetworkHandles in the NetLog were unreadable, fix them to be readable again. R=xunjieli BUG=625188 Committed: https://crrev.com/eef27f6a445e0d16821f3ceebf73ca1a6d083698 Cr-Commit-Position: refs/heads/master@{#413133}

Patch Set 1 #

Total comments: 5

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M net/base/logging_network_change_observer.cc View 1 2 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
pauljensen
Helen, PTAL, thank you!
4 years, 4 months ago (2016-08-18 14:52:26 UTC) #1
xunjieli
https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc File net/base/logging_network_change_observer.cc (right): https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc#newcode56 net/base/logging_network_change_observer.cc:56: base::IntToString(HumanReadableNetworkHandle(active_network)), Why does ">>32" make network handle human readable? ...
4 years, 4 months ago (2016-08-18 16:13:16 UTC) #2
pauljensen
https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc File net/base/logging_network_change_observer.cc (right): https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc#newcode56 net/base/logging_network_change_observer.cc:56: base::IntToString(HumanReadableNetworkHandle(active_network)), On 2016/08/18 16:13:16, xunjieli wrote: > Why does ...
4 years, 4 months ago (2016-08-18 16:16:49 UTC) #3
xunjieli
https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc File net/base/logging_network_change_observer.cc (right): https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc#newcode25 net/base/logging_network_change_observer.cc:25: // On Marshmallow, demunge the NetID to undo munging ...
4 years, 4 months ago (2016-08-18 17:15:17 UTC) #4
pauljensen
https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc File net/base/logging_network_change_observer.cc (right): https://codereview.chromium.org/2251413003/diff/1/net/base/logging_network_change_observer.cc#newcode25 net/base/logging_network_change_observer.cc:25: // On Marshmallow, demunge the NetID to undo munging ...
4 years, 4 months ago (2016-08-19 11:57:48 UTC) #5
xunjieli
lgtm
4 years, 4 months ago (2016-08-19 11:59:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251413003/20001
4 years, 4 months ago (2016-08-19 12:01:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 14:07:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 14:10:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eef27f6a445e0d16821f3ceebf73ca1a6d083698
Cr-Commit-Position: refs/heads/master@{#413133}

Powered by Google App Engine
This is Rietveld 408576698