[MD History] Use modified time to check staleness of vulcanize and crisper.

chrome/browser/resources/md_history/PRESUBMIT.py

Index: chrome/browser/resources/md_history/PRESUBMIT.py
diff --git a/chrome/browser/resources/md_history/PRESUBMIT.py b/chrome/browser/resources/md_history/PRESUBMIT.py
index 0f0b511dd73ff73a9b9b7f9e49837c6636df1161..ba26b9f00a7d02960af016a58d9d46bf0b0d5d19 100644
--- a/chrome/browser/resources/md_history/PRESUBMIT.py
+++ b/chrome/browser/resources/md_history/PRESUBMIT.py
@@ -2,6 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import os.path, time

[tsergeant, 2016/08/19 00:24:37]

Nit: imports on separate lines

[calamity, 2016/08/19 02:01:11]

Done.

 
 def CheckChangeOnUpload(input_api, output_api):
   """Warn when changing md_history without vulcanizing."""
@@ -15,11 +16,15 @@ def CheckChangeOnUpload(input_api, output_api):
     return any([filename in path for path in paths])
 
   paths = [x.LocalPath() for x in input_api.change.AffectedFiles()]
-  vulcanize_changes = (_affects_file('md_history/app.vulcanized.html', paths) or
-                       _affects_file('md_history/app.crisper.js', paths))
+  earliest_vulcanize_change = min(os.path.getmtime(x) for x in
+                                  ['app.vulcanized.html', 'app.crisper.js'])
   history_changes = filter(_is_md_history_file, paths)
+  latest_history_change = 0
+  if history_changes:
+    latest_history_change = max(os.path.getmtime(os.path.split(x)[1]) for x in
+                                history_changes)
 
-  if history_changes and not vulcanize_changes:
+  if latest_history_change > earliest_vulcanize_change:
     return [output_api.PresubmitPromptWarning(
         'Vulcanize must be run when changing files in md_history. See '
         'docs/vulcanize.md.')]