Disable check-webkit-style for Jinja templates

Disable check-webkit-style for Jinja templates

Jinja templates generally use the same extension as their output file,
but contain template code which the style checker can't understand.
(...and thus presubmit checks fail)
This adds a setting in the usual path-specific filters section to not
check these paths.

This is in response to an issue raised by Alan:
https://codereview.chromium.org/21006006/#msg8

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155663

[Nils Barth (inactive), 2013-08-07 01:40:29]

Hiyas,
check-webkit-style doesn't understand Jinja templates,
so we're currently having to hack around this.
This adds an override in the standard way, AFAICT.
Looks ok?

[Dirk Pranke, 2013-08-07 01:42:10]

lgtm

[haraken, 2013-08-07 01:44:03]

LGTM.

Running the style checker for the generated code has sometimes annoyed us (and
complicated the code generator than needed).

[commit-bot: I haz the power, 2013-08-07 01:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/22514002/1

[Nils Barth (inactive), 2013-08-07 01:57:31]

On 2013/08/07 01:44:03, haraken wrote:
> Running the style checker for the generated code has sometimes annoyed us (and
> complicated the code generator than needed).

Is this for:
Source/bindings/tests/results
?
...since check-webkit-style should only run on files in the repo, not generated
files.

We can turn this off too if it helps, after finishing porting.

Right now we're not changing the generated code (just porting),
so not an issue, but once we've finished porting we can see if we can
make it simpler by relaxing style, which seems a reasonable tradeoff.
(Generat*or* legibility being more important than generated *code* legibility.)

However, if the templates mean it's easy to get the style right too,
it seems a nice touch to have.

So I'll look into this later (on my list).

[haraken, 2013-08-07 02:07:43]

On 2013/08/07 01:57:31, Nils Barth wrote:
> On 2013/08/07 01:44:03, haraken wrote:
> > Running the style checker for the generated code has sometimes annoyed us
(and
> > complicated the code generator than needed).
> 
> Is this for:
> Source/bindings/tests/results
> ?
> ...since check-webkit-style should only run on files in the repo, not
generated
> files.
> 
> We can turn this off too if it helps, after finishing porting.

Yes, we might want to do it in a separate CL.

[Nils Barth (inactive), 2013-08-07 02:24:33]

BTW, I just realized that we could run the generated code through clang-format,
which would solve all our formatting problems!
(So we can certainly simplify the code generator.)
OTOH, I suspect this is The Wrong Answer, since it just adds more moving parts.

Upshot: we could automatically format the code correctly, but there's little
benefit
and much complexity.

[commit-bot: I haz the power, 2013-08-07 06:03:34]

Change committed as 155663