Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 2251353005: Restrict UndoTabModelTest#testReverseOrderRestore to phone. (Closed)

Created:
4 years, 4 months ago by Donn Denman
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict UndoTabModelTest#testReverseOrderRestore to phone. This test is flaking on tablets, especially KitKat. BUG=633607 Committed: https://crrev.com/32984105b1059344cf886caf639dc55a530456ae Cr-Commit-Position: refs/heads/master@{#413196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Donn Denman
Dan, PTAL.
4 years, 4 months ago (2016-08-19 17:29:01 UTC) #2
gone
lgtm
4 years, 4 months ago (2016-08-19 18:00:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251353005/1
4 years, 4 months ago (2016-08-19 18:03:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 18:48:16 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 18:50:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32984105b1059344cf886caf639dc55a530456ae
Cr-Commit-Position: refs/heads/master@{#413196}

Powered by Google App Engine
This is Rietveld 408576698